Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/vm/runtime: Add Random field to config #28001

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

guidovranken
Copy link
Contributor

@guidovranken guidovranken commented Aug 24, 2023

Make the Random field configurable through the Runtime interface. The RANDOM opcode will otherwise crash due to a nil pointer if it is run via Runtime.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(is there anything else we've forgotten?)

@holiman
Copy link
Contributor

holiman commented Aug 25, 2023

(is there anything else we've forgotten?)

So, we are not setting the blockContext.ExcessBlobGas field in this invocation, but I think that's fine.

@holiman holiman added this to the 1.13.0 milestone Aug 25, 2023
@holiman holiman merged commit 0ba2d3c into ethereum:master Aug 25, 2023
1 of 2 checks passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants