cmd, core, params: add support for the Holesky testnet #28007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parithosh
approved these changes
Aug 25, 2023
holiman
reviewed
Aug 25, 2023
| return &Genesis{ | ||
| Config: params.HoleskyChainConfig, | ||
| Nonce: 0x1234, | ||
| ExtraData: hexutil.MustDecode("0x686f77206d7563682069732074686520666973683f"), |
There was a problem hiding this comment.
we only added this to check if you review this carefully
holiman
reviewed
Aug 25, 2023
| TerminalTotalDifficultyPassed: true, | ||
| MergeNetsplitBlock: nil, | ||
| ShanghaiTime: newUint64(1694790240), | ||
| CancunTime: newUint64(2000000000), |
There was a problem hiding this comment.
From https://github.com/eth-clients/holesky:
Cancun: (TBD)
There was a problem hiding this comment.
This comment was marked as spam.
This comment was marked as spam.
colindickson
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 11, 2023
* cmd, core, params: add support for the Holesky testnet * cmd/devp2p: add support for holesky for the dns crawler (cherry picked from commit 6b98d18)
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* cmd, core, params: add support for the Holesky testnet * cmd/devp2p: add support for holesky for the dns crawler
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#28007)" This reverts commit 8f5d063.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#28007)" This reverts commit 8f5d063.
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Dec 19, 2023
* cmd, core, params: add support for the Holesky testnet * cmd/devp2p: add support for holesky for the dns crawler # Conflicts: # cmd/devp2p/nodesetcmd.go # cmd/geth/main.go # cmd/utils/flags.go # core/genesis.go # params/bootnodes.go # params/config.go
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.