-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/rawdb: don't warn for missing "unclean shutdown markers" #28014
Conversation
Personally I am not sure if it's necessary, mark it as triage to discuss with team. |
Triage discussion: let's just delete the warning. THe warning only ever happens when people have cleaned their datadirs, it's not a relevant warning -- it works. |
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 370ad81. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 25733a4. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit a456438. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 72e9a72. Signed-off-by: jsvisa <delweng@gmail.com>
…ound" This reverts commit 108adb6. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 340b805. Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
f8aacc2
to
e3f320d
Compare
I adjusted this PR to remove the warning message only, please take another look @rjl493456442 @holiman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…um#28014) This changes removes the warn-printout about not finding unclean shutdown markers, which always happens on fresh installs / wiped databases.
…ethereum#28014)" This reverts commit f3d4945.
…ethereum#28014)" This reverts commit f3d4945.
When a new node is run, especially when running with
--dev
mode, there is always a log below: