core/state: fix statedb.Copy #28094
Closed
core/state: fix statedb.Copy #28094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func (ch createObjectChange) dirtied() *common.Address { | ||
| return ch.account | ||
| } | ||
|
|
||
| func (ch createObjectChange) copy() journalEntry { | ||
| return createObjectChange{ | ||
| account: ch.account, |
There was a problem hiding this comment.
You*re copying the pointer here, right?
|
Please remove me from your mailing list.
…On Tue, Sep 12, 2023, 12:04 AM Marius van der Wijden < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/state/journal.go
<#28094 (comment)>
:
> }
func (ch createObjectChange) dirtied() *common.Address {
return ch.account
}
+func (ch createObjectChange) copy() journalEntry {
+ return createObjectChange{
+ account: ch.account,
You*re copying the pointer here, right?
—
Reply to this email directly, view it on GitHub
<#28094 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVDM3FBENGTBNEOORD7F4LTX2ACRPANCNFSM6AAAAAA4UGVHXE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
rjl493456442
commented
Sep 12, 2023
| @@ -154,13 +175,18 @@ type ( | |||
|
|
|||
| func (ch createObjectChange) revert(s *StateDB) { | |||
| delete(s.stateObjects, *ch.account) | |||
| delete(s.stateObjectsDirty, *ch.account) | |||
There was a problem hiding this comment.
It's totally wrong to modify the Dirty map, which is the marker for state commit and is only modified at the transaction boundary. An internal state revert should never touch it.
rjl493456442
force-pushed
the
fix-statedb
branch
from
bd55fb5
to
1ca8f85
Compare
|
Replaced by #28666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this PR is very sensitive by touching very core part, and it's not a big/practical issue, open it here for getting general feedbacks. It's not urge to merge it.