Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: rename the protocols field in the metrics gague #28102

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

karalabe
Copy link
Member

The eth_protocol seems wrong (it contains all protocols, the eth part originates from the "eth" service the protocols are from, but that's moot in the context of Geth). This PR drops the eth_ prefix.

F55OMNQakAA-HJV

@karalabe karalabe added this to the 1.13.1 milestone Sep 13, 2023
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit eb74389 into ethereum:master Sep 13, 2023
1 check passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants