Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: abort on api operations not available in pbss-mode #28104

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Sep 13, 2023

The trie flush interval does not make sense in path scheme anyway. We could return a value for getAccessibleState later on when historical state is merged in, for now return error.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.13.1 milestone Sep 14, 2023
@holiman holiman changed the title eth: abort on api calls not supporting pbss eth: abort on api operations not available in pbss-mode Sep 14, 2023
@holiman holiman merged commit b9b99a1 into ethereum:master Sep 14, 2023
2 checks passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants