Correctly calculate effective gas price #28130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release doesn't calculate the effective gas price correctly. The behavior implemented is
price = min(gasTipCap + baseFee, gasTipCap)
, but it is supposed to beprice = min(gasTipCap + baseFee, gasFeeCap)
, according to the comment aboveeffectiveGasPrice()
.As an example, this can be observed by calling
eth_getBlockByNumber
, and observing that thegasPrice
andmaxPriorityFeePerGas
are equivalent for all reported transactions.