Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/devp2p: use bootnodes as crawl input #28139

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Sep 18, 2023

In This PR, we can use --bootnodes to start a devp2p crawl, the flag will take effect if the input/output.json file is missing or empty. Also in this PR, we cannot begin crawling if no input nodes are provided.

close #27942

Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
@fjl fjl added this to the 1.13.2 milestone Sep 19, 2023
@fjl fjl changed the title cmd/devp2p: use bootnodes as the alternate of crawl input cmd/devp2p: use bootnodes as crawl input Sep 19, 2023
@fjl fjl merged commit 41a0ad9 into ethereum:master Sep 19, 2023
1 of 2 checks passed
@jsvisa jsvisa deleted the cmd-devp2p-use-bootnodes-as-input branch September 19, 2023 12:23
phenix3443 pushed a commit to phenix3443/go-ethereum that referenced this pull request Sep 19, 2023
This PR makes the tool use the --bootnodes list as the input to devp2p crawl.
The flag will take effect if the input/output.json file is missing or empty.
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
This PR makes the tool use the --bootnodes list as the input to devp2p crawl.
The flag will take effect if the input/output.json file is missing or empty.
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
This PR makes the tool use the --bootnodes list as the input to devp2p crawl.
The flag will take effect if the input/output.json file is missing or empty.
siosw pushed a commit to fabriqnetwork/go-ethereum that referenced this pull request Oct 16, 2023
This PR makes the tool use the --bootnodes list as the input to devp2p crawl.
The flag will take effect if the input/output.json file is missing or empty.
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This PR makes the tool use the --bootnodes list as the input to devp2p crawl.
The flag will take effect if the input/output.json file is missing or empty.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devp2p discv4 crawl does NOT WORK
2 participants