Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: move light.NodeSet to trienode.ProofSet #28287

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Oct 9, 2023

This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes.

@holiman holiman changed the title all: move NodeSet from light to trie all: move NodeSet from light to trie/trienode Oct 9, 2023
@holiman holiman changed the title all: move NodeSet from light to trie/trienode all: move light.NodeSet to trienode.ProofSet Oct 9, 2023
trie/trienode/node.go Outdated Show resolved Hide resolved
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, otherwise lgtm

@holiman holiman added this to the 1.13.3 milestone Oct 10, 2023
@holiman holiman merged commit 6b1e4f4 into ethereum:master Oct 10, 2023
1 of 2 checks passed
@holiman holiman deleted the trie_prep branch October 11, 2023 07:23
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023
This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Jan 31, 2024
This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants