Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/fetcher: only make noise big mismatches #28356

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

karalabe
Copy link
Member

Erigon is sending bad tx announces. We should drop them, but that would hurt the network. We were loud, but that hurts users. Let's lower the verbosity, get them to fix it and then raise it back up again.

@karalabe karalabe added this to the 1.13.4 milestone Oct 16, 2023
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anewt95

This comment was marked as spam.

anewt95

This comment was marked as spam.

@ethereum ethereum deleted a comment from anewt95 Nov 2, 2023
@ethereum ethereum deleted a comment from anewt95 Nov 2, 2023
@ethereum ethereum deleted a comment Nov 2, 2023
@ethereum ethereum deleted a comment from anewt95 Nov 2, 2023
@ethereum ethereum deleted a comment from samuelmonday699 Nov 2, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants