Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: increase timeout in TestClientWebsocketPing #28371

Merged
merged 2 commits into from
Oct 19, 2023
Merged

rpc: increase timeout in TestClientWebsocketPing #28371

merged 2 commits into from
Oct 19, 2023

Conversation

bnovil
Copy link
Contributor

@bnovil bnovil commented Oct 18, 2023

fix #28369

rjl493456442
rjl493456442 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@holiman
Copy link
Contributor

holiman commented Oct 18, 2023

The fix might work, but unfortunately it's one of those deadlines that, when bumped to 5s, bumps the test execution time to 5s too. So it adds 4s to the CI execution time.

However, it's not easy to refactor the test to avoid this, since it has some history in #19798 (comment) , and one needs to fully grokk the reason for how the ctx is used, before doing any larger changes.

So I guess the change here is fine, but I'd prefer to bump it to 2s instead of the full 5s from the get-go.

@bnovil
Copy link
Contributor Author

bnovil commented Oct 18, 2023

2s seems better, thanks for your advice @holiman

holiman
holiman approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl changed the title rpc: fix TestClientWebsocketPing rpc: increase timeout in TestClientWebsocketPing Oct 19, 2023
@fjl fjl merged commit ec1a050 into ethereum:master Oct 19, 2023
1 of 2 checks passed
@fjl fjl added this to the 1.13.5 milestone Oct 19, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@bnovil @devopsbo3
rpc: increase timeout in TestClientWebsocketPing (ethereum#28371)
ba43767
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "rpc: increase timeout in TestClientWebsocketPing (ethereum#28371
1dd23c2 
)"

This reverts commit ba43767.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "rpc: increase timeout in TestClientWebsocketPing (ethereum#28371
3857923 
)"

This reverts commit ba43767.
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@bnovil @Dergarcon
rpc: increase timeout in TestClientWebsocketPing (ethereum#28371)
74a7aac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman holiman approved these changes

@fjl fjl Awaiting requested review from fjl fjl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.5
Development

Successfully merging this pull request may close these issues.

Please fix the flaky test
4 participants
@bnovil @holiman @rjl493456442 @fjl