Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/filters: fix flaky test #28376

Merged
merged 3 commits into from
Oct 19, 2023
Merged

eth/filters: fix flaky test #28376

merged 3 commits into from
Oct 19, 2023

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Oct 18, 2023 •
edited
Loading

I used a private field in the test which is ugly but the test isn't using a constant timeout which should be more reliable.

--- FAIL: TestPendingTxFilterDeadlock (0.43s)
    filter_system_test.go:945: Filter 0xb8eae786b9803d3d609b2c821eb1063b should have been uninstalled
    filter_system_test.go:945: Filter 0x9c29340950cc32a5d529614bc7eebba6 should have been uninstalled
    filter_system_test.go:945: Filter 0xee2adcbcb566863626d022fd9a7cf25d should have been uninstalled
    filter_system_test.go:945: Filter 0x9787a8ad2029820e12ec76c42834669b should have been uninstalled
    filter_system_test.go:945: Filter 0x4ed8bcb649c19fb643819d1a0a4c7d5 should have been uninstalled
    filter_system_test.go:945: Filter 0x63649cc3a9ff47d4fae0f9c288b03e57 should have been uninstalled
    filter_system_test.go:945: Filter 0xc70de5b5187afa7c319b1dfb2af863a should have been uninstalled
    filter_system_test.go:945: Filter 0x5c29489f19b2a13ef169381abc725d0 should have been uninstalled
    filter_system_test.go:945: Filter 0x8d45e09c46026e74d867a233c8cdba1c should have been uninstalled
FAIL
FAIL	github.com/ethereum/go-ethereum/eth/filters	4.506s

For context this test was added to cover the deadlock reported here: #22131

@s1na s1na changed the title eth/filters: bump timeout on flaky test eth/filters: fix flaky test Oct 18, 2023
fjl
fjl approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl added this to the 1.13.5 milestone Oct 19, 2023
@fjl fjl merged commit 4d3c0d4 into ethereum:master Oct 19, 2023
1 of 2 checks passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@s1na @devopsbo3
eth/filters: fix flaky test TestPendingTxFilterDeadlock (ethereum#28376)
492977c
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "eth/filters: fix flaky test TestPendingTxFilterDeadlock (ethe…
75890f7 
…reum#28376)"

This reverts commit 492977c.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "eth/filters: fix flaky test TestPendingTxFilterDeadlock (ethe…
4543389 
…reum#28376)"

This reverts commit 492977c.
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@s1na @Dergarcon
eth/filters: fix flaky test TestPendingTxFilterDeadlock (ethereum#28376)
4790af3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.5
Development

Successfully merging this pull request may close these issues.
2 participants
@s1na @fjl