ethstats: fix bug in block reporting #28398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
LGTM, looks like this was broken by cd31f2d
where CurrentBlock was changed to return a header, which fails the type assertion on line 634
holiman
reviewed
Oct 23, 2023
holiman
reviewed
Oct 23, 2023
|
@holiman Done |
ghost
requested a review
from 
holiman
changed the title
|
Thanks! |
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Fixes a bug where the ethstats omits to report full block contents. This bug was a side-effect of ethereum#26777, where `CurrentBlock` was changed to return a header instead of a block, leading to a failed type assertion.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit a4ebc4d.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit a4ebc4d.
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
Fixes a bug where the ethstats omits to report full block contents. This bug was a side-effect of ethereum#26777, where `CurrentBlock` was changed to return a header instead of a block, leading to a failed type assertion.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Geth always reporting 0 txs per block while other node implementations report it correctly on https://ethstats.dev/.