Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm: Add --single-test option to blocktest #28421

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

marioevz
Copy link
Member

Adds --single-test option to evm blocktest to run a single test from a given json BlockchainTest file.

This allows execution-spec-tests to verify each of the tests it produces individually, because at the moment we verify the entire json file and it's not simple to detect which one of the included tests was the one that failed.

@lightclient
Copy link
Member

lightclient commented Oct 31, 2023

@marioevz I made a bit of a modification to follow the go test --run {regexp} style a little more closely. Let me know if this change looks okay to you.

--

If others want to play along at home, you can verify this is working with

$  go run ./cmd/evm blocktest --run 100-fork=Cancun-empty_memory-length=0-src=0-dest=0 ./tests/spec-tests/fixtures/cancun/eip5656_mcopy/mcopy/mcopy_on_empty_memory.json

@marioevz
Copy link
Member Author

Thanks for the help @lightclient ! It looks fine to me but I'm tagging @danceratopz since he's working on the feature that uses this change.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like 👍 from Dan too

@danceratopz
Copy link
Member

looks like 👍 from Dan too

Yup, works nicely on our side, thanks!

@fjl fjl merged commit 285202a into ethereum:master Oct 31, 2023
1 of 2 checks passed
@fjl fjl added this to the 1.13.5 milestone Oct 31, 2023
@fjl fjl removed the status:triage label Oct 31, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Co-authored-by: lightclient <lightclient@protonmail.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
Co-authored-by: lightclient <lightclient@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants