Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethclient: add empty/nonexist account testcase for eth_getProof RPC #28482

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Nov 8, 2023

I apologize for the inappropriate fix for the issue #28441. Here, I have added two new test cases to differentiate between the scenarios:

  1. the account/contract does not exists;
  2. the account/contract exists but is empty.

Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it's always good to have tests to document the as-is, regardless of wether we consider it to be the end-all and final behaviour. Just so we don't unintentionally change things.

LGTM!

@holiman holiman added this to the 1.13.5 milestone Nov 10, 2023
@holiman holiman merged commit ce5a480 into ethereum:master Nov 10, 2023
2 checks passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
…thereum#28482)

Adds testcases for eth_getProof endpoint for the following cases: 

- the account/contract does not exist
- the account/contract exists but is empty.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
…thereum#28482)

Adds testcases for eth_getProof endpoint for the following cases: 

- the account/contract does not exist
- the account/contract exists but is empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants