cmd/geth: more testcases for logging #28501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds more edgecases around logging, particularly around handling of different types of nil-values as concrete types and within interfaces. Also adds tests with 'reserved' values which breaks json/logfmt formats. The json output is checked in, but not actively used by any testcase at the moment.
holiman
commented
Nov 9, 2023
| {"lvl":"info","msg":"nil-custom-struct","res":"\u003cnil\u003e","t":"2023-11-09T08:33:19.465638888+01:00"} | ||
| {"lvl":"info","msg":"raw nil","res":"\u003cnil\u003e","t":"2023-11-09T08:33:19.465673664+01:00"} | ||
| {"lvl":"info","msg":"(*uint64)(nil)","res":"\u003cnil\u003e","t":"2023-11-09T08:33:19.465700264+01:00"} | ||
| {"level":"level","lvl":"lvl","msg":"msg","t":"t","time":"time"} |
There was a problem hiding this comment.
cc @jwasinger our old logger is broken: it simply overwrites the 'native' t with whatever the caller specified. So there's no need to make the new one behave better.
There was a problem hiding this comment.
okay. slog text/json handlers produce a duplicate field instead of overwriting in this case.
holiman
commented
Nov 9, 2023
| t=2023-11-09T08:26:52+0100 lvl=info msg=nil-custom-struct res=<nil> | ||
| t=2023-11-09T08:26:52+0100 lvl=info msg="raw nil" res=nil | ||
| t=2023-11-09T08:26:52+0100 lvl=info msg=(*uint64)(nil) res=<nil> | ||
| t=2023-11-09T08:30:19+0100 lvl=info msg="Using keys 't', 'lvl', 'time', 'level' and 'msg'" t=t time=time lvl=lvl level=level msg=msg |
There was a problem hiding this comment.
The old logfmt handler actually does handle multiple keys. Oh well. Still a programming-error, IMO
holiman
commented
Nov 9, 2023
Comment on lines
+45
to
+47
| INFO [XX-XX|XX:XX:XX.XXX] error(nil) res=nil | ||
| INFO [XX-XX|XX:XX:XX.XXX] nil-concrete-error res= | ||
| INFO [XX-XX|XX:XX:XX.XXX] nil-custom-struct res=<nil> |
There was a problem hiding this comment.
Three flavours of expressing nil. Sheesh
jwasinger
approved these changes
Nov 9, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* cmd/geth: more testcases for logging This adds more edgecases around logging, particularly around handling of different types of nil-values as concrete types and within interfaces. Also adds tests with 'reserved' values which breaks json/logfmt formats. The json output is checked in, but not actively used by any testcase at the moment. * cmd/geth/testdata: remove timestamps
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 49a09d7.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 49a09d7.
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
* cmd/geth: more testcases for logging This adds more edgecases around logging, particularly around handling of different types of nil-values as concrete types and within interfaces. Also adds tests with 'reserved' values which breaks json/logfmt formats. The json output is checked in, but not actively used by any testcase at the moment. * cmd/geth/testdata: remove timestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more edgecases around logging, particularly around handling of different types of nil-values as concrete types and within interfaces.
Also adds tests with 'reserved' values which breaks json/logfmt formats. The json output is checked in, but not actively used by any testcase at the moment.
I also removed the timestamps from the output, to remove some of the 'false postives' when we make any changes to it.
This PR is in preparation of #28187