Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb: implement size reporting for live items in freezer_table #28525

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

wangyifan
Copy link
Contributor

This is the fix to issue #27483. A new hiddenBytes() is introduced to calculate the byte size of hidden items in the freezer table. When reporting the size of the freezer table, size of the hidden items will be subtracted from the total size.

…e.go to account for hidden items due to tail deletions (ethereum#27483)
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pull request can detect the size of hidden data while the hidden indexes are still counted for size. But perhaps it's already better than the original version.

@holiman holiman changed the title core/rawdb: Implemented size reporting for live items in freezer_table core/rawdb: implemented size reporting for live items in freezer_table Dec 18, 2023
@holiman holiman changed the title core/rawdb: implemented size reporting for live items in freezer_table core/rawdb: implement size reporting for live items in freezer_table Dec 18, 2023
@holiman holiman modified the milestones: 1.13.6, 1.13.7 Dec 18, 2023
@holiman holiman merged commit cd58897 into ethereum:master Dec 18, 2023
3 checks passed
Copy link

@Jircs1 Jircs1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/rawdb/freezer_table_test.go

Doozers pushed a commit to kilnfi/pgeth that referenced this pull request Dec 22, 2023
…thereum#28525)

This is the fix to issue ethereum#27483. A new hiddenBytes() is introduced to calculate the byte size of hidden items in the freezer table. When reporting the size of the freezer table, size of the hidden items will be subtracted from the total size.

---------

Co-authored-by: Yifan <Yifan Wang>
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
…thereum#28525)

This is the fix to issue ethereum#27483. A new hiddenBytes() is introduced to calculate the byte size of hidden items in the freezer table. When reporting the size of the freezer table, size of the hidden items will be subtracted from the total size.

---------

Co-authored-by: Yifan <Yifan Wang>
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants