Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slog: faster and less memory-consumption #28621

Merged
merged 8 commits into from
Dec 1, 2023
Merged

slog: faster and less memory-consumption #28621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0c8b6ca
log: better benchmark
holiman Nov 7, 2023
4b6d32d
log: improve benchmark
holiman Nov 29, 2023
99f3e24
log: lots of optimizations to terminal output
holiman Nov 7, 2023
d929f63
log: save some cpu by simplifying coloring, avoid many cases of escaping
holiman Nov 14, 2023
632a3f8
remove commented code and no-op space
jwasinger Nov 20, 2023
d2251af
log: format nil as <nil> by default
holiman Nov 29, 2023
b7933d2
log: avoid using go 1.21-specific features
holiman Nov 29, 2023
05d7169
log: lint nits
holiman Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/testlog/testlog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,7 @@ func (h *bufHandler) terminalFormat(r slog.Record) string {
}

for _, attr := range attrs {
rawVal := attr.Value.Any()
fmt.Fprintf(buf, " %s=%s", attr.Key, log.FormatLogfmtValue(rawVal, true))
fmt.Fprintf(buf, " %s=%s", attr.Key, string(log.FormatSlogValue(attr.Value, true, nil)))
}
buf.WriteByte('\n')
return buf.String()
Expand Down
Loading