miner: refactor the miner, make the pending block on demand #28623

MariusVanDerWijden · 2023-11-29T11:13:11Z

This PR tries to refactor the miner. It gets rid of the pending block creation in the background.
The pending block is still created on demand when someone requests a pending block and cached for 1 second.

OBS This PR makes it so that clique-sealing can no longer be performed, disabling --mine

miner/builder.go

cmd/utils/flags.go

miner/miner.go

lightclient · 2023-12-07T15:24:57Z

miner/miner.go

+		random:      common.Hash{},
+		withdrawals: nil,
+		beaconRoot:  nil,


Annoying these are empty since they are "known" (be the CL only though) and "required" per consensus to be included in the next block.

but I understand why..... :')

miner/payload_building.go

holiman

The code looks good and clean. Maybe we should just have a brief call about it: the code isn't complex, but the potential side-effects aren't at all triival in my mind.

miner/miner.go

Given the discussions around deprecating pending (see #28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead

miner/miner.go

lightclient

This is really great; cleans up a lot of artifacts from PoW mining. I had a few additional comments beyond the PR line comments:

I find the interplay between Miner and environment to be a bit confusing now. It feels like it would be clearer if environment was renamed to task and all the methods like fillTransactions(..), commitTransactions(..), etc were methods on task. As it is currently, it feels we're to call fillTransactions(..) on Miner when the main effect is actually happening to the environment object. AFAICT, the only reason it is on Miner is to access the chain and config. Those could be ref'd in task.
Overall, environment makes less since to me now that blocks are built on-demand. Seems like we could organize the code so that we don't need to pass this struct of env data around to a bunch of methods. Or at least reduce the scope of environment. For instance, the blobs int is only useful in fillTransaction(..).
Maybe move miner.buildPayload(..) to miner.go? And generally all Miner methods into the same location?

miner/miner.go

miner/pending.go

miner/stress/main.go

miner/worker.go

rjl493456442 · 2024-01-22T07:33:58Z

cmd/utils/flags.go

@@ -1509,7 +1509,7 @@ func setMiner(ctx *cli.Context, cfg *miner.Config) {
 		cfg.Recommit = ctx.Duration(MinerRecommitIntervalFlag.Name)
 	}
 	if ctx.IsSet(MinerNewPayloadTimeout.Name) {
-		cfg.NewPayloadTimeout = ctx.Duration(MinerNewPayloadTimeout.Name)


Should we deprecate NewPayloadTimeout flag?

Originally

Recommit is used to specify the interval for re-creating pending block

NewPayloadTimeout is used to specify the maximum time allowance for creating a single pending block

I agree that these two flags are kind of overlapped, especially after getting rid of the PUSH mode in miner.

Given the discussions around deprecating pending (see ethereum#28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead

eth/api_miner.go

MariusVanDerWijden · 2024-02-13T13:59:11Z

This test is flaky now:

--- FAIL: TestEthClient (1.13s)
    --- FAIL: TestEthClient/AtFunctions (1.00s)
        ethclient_test.go:615: unexpected pending, wanted 1 got: 0
FAIL
FAIL	github.com/ethereum/go-ethereum/ethclient	1.161s

eth/filters/filter_system.go

ethstats/ethstats.go

internal/web3ext/web3ext.go

miner/miner.go

eth/backend.go

miner/pending.go

karalabe

SGTM, WCGW

commit 94579932b18931115f28aa7f87f02450bda084c9 Author: Mario Vega <marioevz@gmail.com> Date: Tue Apr 23 07:10:24 2024 -0600 core/vm: fix Prague contracts (#29612) core/vm: fix prague contracts commit 256d4b099cf540ba99181d6e746d4a1eaebef054 Author: Felföldi Zsolt <zsfelfoldi@gmail.com> Date: Tue Apr 23 13:31:32 2024 +0200 beacon/light: request finality update explicitly when necessary (#29567) This PR adds an extra mechanism to sync.HeadSync that tries to retrieve the latest finality update from every server each time it sends an optimistic update in a new epoch (unless we already have a validated finality update attested in the same epoch). Note that this is not necessary and does not happen if the new finality update is delivered before the optimistic update. The spec only mandates light_client_finality_update events when a new epoch is finalized. If the chain does not finalize for a while then we might need an explicit request that returns a finality proof that proves the same finality epoch from the latest attested epoch. commit b2b0e1da8cac279bf0466885d1abdc5d93402f41 Author: haoran <159284258+hr98w@users.noreply.github.com> Date: Tue Apr 23 18:09:42 2024 +0800 all: fix various typos (#29600) * core: fix typo * rpc: fix typo * snap: fix typo * trie: fix typo * main: fix typo * abi: fix typo * main: fix field comment for basicOp commit 709e0b399712f113a907936b9f73da8c33afd3f1 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Tue Apr 23 18:08:02 2024 +0800 metrics: remove librato (#29624) commit 0e380ddaf7d9ccba87d3a3688a3fb419b562451c Author: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> Date: Tue Apr 23 18:06:25 2024 +0800 miner: fix typos (#29625) commit 853e0c23f36579423dbac8b4bcb9eeedb53daa9b Author: Martin HS <martin@swende.se> Date: Tue Apr 23 10:33:36 2024 +0200 eth/catalyst, trie/pathdb: fix flaky tests (#29571) This change fixes three flaky tests `TestEth2AssembleBlock`,`TestEth2NewBlock`, `TestEth2PrepareAndGetPayload` and `TestDisable`. --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com> commit acd1eaae2c5006dd7f5ae42455bc7f61e5471013 Author: rjl493456442 <garyrong0905@gmail.com> Date: Tue Apr 23 01:00:42 2024 +0800 core: remove bad block checks (#29609) commit e6689fe090cc56cb3f0c1948c5e5356ea1d20c1e Author: Felföldi Zsolt <zsfelfoldi@gmail.com> Date: Mon Apr 22 13:19:42 2024 +0200 beacon/light/sync: print error log if checkpoint retrieval fails (#29532) Co-authored-by: Felix Lange <fjl@twurst.com> commit 1ec7af261223d6dad9370ee8263f86347b190bab Author: Ryan Schneider <ryanleeschneider@gmail.com> Date: Mon Apr 22 03:17:06 2024 -0700 eth: Add eth_blobBaseFee RPC and blob fields to eth_feeHistory (#29140) Co-authored-by: lightclient <lightclient@protonmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> commit c2dfe7a0c7321615e2524f1c677266de26d30d05 Author: Péter Szilágyi <peterke@gmail.com> Date: Mon Apr 22 12:56:54 2024 +0300 go.mod: update golang/x repos (#29604) commit 82b0dec7135b281c1b03064d50959dc992c2f94f Author: Felix Lange <fjl@twurst.com> Date: Mon Apr 22 10:31:17 2024 +0200 eth/filters: remove support for pending logs (#29574) This change removes support for subscribing to pending logs. "Pending logs" were always an odd feature, because it can never be fully reliable. When support for it was added many years ago, the intention was for this to be used by wallet apps to show the 'potential future token balance' of accounts, i.e. as a way of notifying the user of incoming transfers before they were mined. In order to generate the pending logs, the node must pick a subset of all public mempool transactions, execute them in the EVM, and then dispatch the resulting logs to API consumers. commit ad3d8cb12a368ea901a2b36b0708480065235308 Author: xiaodong <81516175+javaandfly@users.noreply.github.com> Date: Mon Apr 22 16:13:03 2024 +0800 cmd/geth: remove unused parameter (#29602) commit 28ccb2bbf82af487da856d459d4daaa7c0d9b064 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Sun Apr 21 17:14:13 2024 +0800 build: fix string compare for SortFunc (#29595) commit 98f504f69fad798c03ad43a1fc40f243d2fc8215 Author: bugmaker9371 <167614621+bugmaker9371@users.noreply.github.com> Date: Sun Apr 21 17:13:36 2024 +0800 p2p/discover: fix test error messages (#29592) commit 2e06fbd409d64a400c19d26d7af383f868e34f11 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Fri Apr 19 13:46:43 2024 +0200 core/vm: add KZG benchmark (#29583) commit cce879b71b772ca9df83ada499127d6ca8e7c8f6 Author: Mario Vega <marioevz@gmail.com> Date: Fri Apr 19 02:07:52 2024 -0600 tests: define cancun-to-prague at 15K chainconig (#29557) tests: add cancun->prague config commit 81349ff6e53a5bcb7adee210274171c22ae64053 Author: ids <tonyhaha163@163.com> Date: Fri Apr 19 15:58:14 2024 +0800 eth/catalyst: fix typo (#29580) commit 823719b9e1b72174cd8245ae9e6f6f7d7072a8d6 Author: Martin HS <martin@swende.se> Date: Thu Apr 18 09:08:25 2024 +0200 core/vm: enable bls-precompiles for Prague (#29552) enables the bls-contracts on the "Prague" config, so that the testing-team can activate them to make tests. commit b5902cf595b3d83f6fa96b5a501213daec169f15 Author: rjl493456442 <garyrong0905@gmail.com> Date: Thu Apr 18 14:48:50 2024 +0800 core: remove unused fields (#29569) commit 5f9514530818c4436238d4740111bd699470f0f1 Author: ucwong <ucwong@126.com> Date: Thu Apr 18 07:21:23 2024 +0100 eth/ethconfig: regenerate autogen files (#29559) eth/ethconfig/gen_config.go : go generate fix commit 0da69e84c0d481e42f60cecc1562c208525117eb Author: Felföldi Zsolt <zsfelfoldi@gmail.com> Date: Wed Apr 17 17:07:28 2024 +0200 beacon/blsync: proceed with empty finalized hash if proof is not expected soon (#29449) * beacon/blsync: proceed with empty finalized hash if proof is not expected soon * Update beacon/blsync/block_sync.go Co-authored-by: Felix Lange <fjl@twurst.com> * beacon/blsync: fixed linter warning * Update beacon/blsync/block_sync.go Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> --------- Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> commit 1e9bf2a09ed3d82ac1aa69750a556f3ce127721d Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Wed Apr 17 19:55:31 2024 +0800 core/state: fix bug in statedb.Copy and remove unnecessary preallocation (#29563) This change removes an unnecessary preallocation and fixes a flaw with no-op copies of some parts of the statedb commit 74e8d2da97aacc2589d39584f6af74cb9d62ee3f Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Wed Apr 17 14:24:30 2024 +0800 trie/utils: simplify codeChunkIndex (#29480) minor simplification to the code commit 27de7dec658839722c8d84963d0a9b0c09a25d25 Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Apr 17 13:52:08 2024 +0800 ethdb/pebble: print warning log if pebble performance degrades (#29478) commit 92da96b7d5400f006774e15d154f5fa8ea1ebd9f Author: Devon Bear <itsdevbear@berachain.com> Date: Tue Apr 16 08:57:57 2024 -0400 core/vm: refactor push-functions to use `min` builtin (#29515) * optimize-push * revert push1 change * Update instructions.go * core/vm: go format * core/vm: fix nit --------- Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com> commit 0a5102881975120b5d321e40c325edba778314d8 Author: persmor <166146971+persmor@users.noreply.github.com> Date: Tue Apr 16 21:44:00 2024 +0900 all: fix various typos (#29542) * core/rawdb: fix typos * accounts/abi: fix typos * metrics: fix typo * beacon: fix typo * crypto: fix typo * rpc: fix typo * rpc: fix typo commit 5ffd940b7e67ba7bb3810a9ed234b5dc45c23cdb Author: ucwong <ucwong@126.com> Date: Tue Apr 16 13:42:16 2024 +0100 core: go fmt (#29544) commit 65e32d47ea336b56d6c4bcfe212c11e8f38032bf Author: ucwong <ucwong@126.com> Date: Tue Apr 16 13:32:50 2024 +0100 go.mod: clean up indirection (#29553) commit 72f69366de1d09fbe4738982fec9948ed5a69892 Author: Chris Ziogas <ziogaschr@gmail.com> Date: Tue Apr 16 15:31:19 2024 +0300 c.d/utils: rename vmtrace.config to vmtrace.jsonconfig (#29554) rename vmtrace.config to vmtrace.jsonconfig for consinstency with t8ntool trace.jsonconfig commit fadd9d8b81324b0d4405de2837ac9939b2cef6c5 Author: law wang <915337710@qq.com> Date: Tue Apr 16 17:21:20 2024 +0800 eth/catalyst: fix log (#29549) log:output the correct variable Co-authored-by: steven <steven@stevendeMacBook-Pro.local> commit f437307877f4c8e423f787de5c9636b985d322f5 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Tue Apr 16 10:53:43 2024 +0200 core/vm: update gascosts for BLS12-381 + use gnark instead of kilic (#29441) This PR updates the bls contracts from our internal implementation which is an unmaintained fork of the kilic library to the gnark-crypto library that is actively maintained by consensys. It also updates the gas-costs according to the EIP commit 71c78bf56da29dc8b85cddc9da09eabf18131ee8 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Tue Apr 16 01:38:25 2024 -0700 rpc: close Clients in tests (#29512) commit e4ecaf89cf5ee6233094f738c4978020fe63e237 Author: Marcus Baldassarre <baldassarremarcus@gmail.com> Date: Tue Apr 16 04:37:18 2024 -0400 rpc: implement Unwrap() for wsHandshakeError (#29522) commit d3c4466edd43fff9ac30162073795d8776070c5d Author: rjl493456442 <garyrong0905@gmail.com> Date: Tue Apr 16 15:05:36 2024 +0800 core, eth/protocols/snap, trie: fix cause for snap-sync corruption, implement gentrie (#29313) This pull request defines a gentrie for snap sync purpose. The stackTrie is used to generate the merkle tree nodes upon receiving a state batch. Several additional options have been added into stackTrie to handle incomplete states (either missing states before or after). In this pull request, these options have been relocated from stackTrie to genTrie, which serves as a wrapper for stackTrie specifically for snap sync purposes. Further, the logic for managing incomplete state has been enhanced in this change. Originally, there are two cases handled: - boundary node filtering - internal (covered by extension node) node clearing This changes adds one more: - Clearing leftover nodes on the boundaries. This feature is necessary if there are leftover trie nodes in database, otherwise node inconsistency may break the state healing. commit ef5ac3fb7ae5bf41a465cc32845631f01ff823ef Author: Martin HS <martin@swende.se> Date: Mon Apr 15 17:35:35 2024 +0200 eth/filters: enforce topic-limit early on filter criterias (#29535) This PR adds a limit of 1000 to the "inner" topics in a filter-criteria commit 67422e2a565784edaeade7d3bb747dc13f6863cf Author: Seungbae Yu <dbadoy4874@gmail.com> Date: Mon Apr 15 21:58:17 2024 +0900 p2p/nat: fix typos in comments (#29536) commit 84b12df09e0a67e99a3943f26ccf1b6e6c19a85a Author: Martin HS <martin@swende.se> Date: Mon Apr 15 14:54:51 2024 +0200 core/rawdb: add sanity-limit to header accessor (#29534) commit 3705acd1a97b2cc9bbb092b326a9d8cfbc42037a Author: yudrywet <166895665+yudrywet@users.noreply.github.com> Date: Mon Apr 15 14:40:42 2024 +0800 cmd/utils: fix typo in comment (#29528) commit b179b7b8e7c9cac7ac21da385dbedc9f24ce3755 Author: Abirdcfly <fp544037857@gmail.com> Date: Mon Apr 15 14:34:31 2024 +0800 all: remove duplicate word in comments (#29531) This change removes some duplicate words in in comments commit bd91810462187086b2715fd343aa427e181d89a2 Author: forestkeeperio.eth <87507039+ForestKeeperIO@users.noreply.github.com> Date: Thu Apr 11 05:06:49 2024 -0600 cmd: fix some typos in readmes (#29405) * Update README.md updated for readability * Update rules.md Updated for readability and typos commit b9010f3e872492c1513c853cb5f3f8ce03eff2b5 Author: Newt6611 <45097780+Newt6611@users.noreply.github.com> Date: Thu Apr 11 16:30:15 2024 +0800 rpc: fix comment grammar (#29507) commit 9dcf8aae4742cc4220065489a5bdcf045c398616 Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Apr 10 17:02:45 2024 +0800 eth/protocols/snap: skip retrieval for completed storages (#29378) * eth/protocols/snap: skip retrieval for completed storages * eth/protocols/snap: address comments from peter * eth/protocols/snap: add comments commit 34aac1d7562bf141fe6da1d4f3cdea8819e7b23b Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Tue Apr 9 18:14:30 2024 +0800 all: use big.Sign to compare with zero (#29490) commit f202dfdd478467ffa44217fe414ec8c31a793dff Author: Sina M <1591639+s1na@users.noreply.github.com> Date: Tue Apr 9 12:12:02 2024 +0200 core/tracing: add changelog (#29388) Co-authored-by: Matthieu Vachon <matthieu.o.vachon@gmail.com> commit 0bbd88bda04698c457077318ae8442e2611ea3b0 Author: Bin <49082129+songzhibin97@users.noreply.github.com> Date: Tue Apr 9 14:51:54 2024 +0800 all: use timer instead of time.After in loops, to avoid memleaks (#29241) time.After is equivalent to NewTimer(d).C, and does not call Stop if the timer is no longer needed. This can cause memory leaks. This change changes many such occations to use NewTimer instead, and calling Stop once the timer is no longer needed. commit 1126c6d8a57f1b7d9af0b39ac52f6eeb435f66f9 Author: rjl493456442 <garyrong0905@gmail.com> Date: Tue Apr 9 14:37:18 2024 +0800 core: add txlookup lock (#29343) This change adds a lock to the transaction lookup cache, to avoid the case where reorgs make the lookup return inconsistent results. commit 3caf617dcdee9fc1d2e9070bfdba370b20231884 Author: cui <523516579@qq.com> Date: Tue Apr 9 14:33:36 2024 +0800 core/vm: move bls precompiles to correct addresses (#29445) core: make bls precompiled contract use the correct address as in eip commit f447de936c31e6a64470f3c102da85f245fe9640 Author: Mohanson <mohanson@outlook.com> Date: Tue Apr 9 14:27:13 2024 +0800 rlp: replace reflect.PtrTo with reflect.PointerTo (#29488) reflect.PtrTo has been deprecated and superseded by reflect.PointerTo commit 70bf94c34e4a6320c865a90cbfeec38a0aef7378 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Tue Apr 9 14:22:53 2024 +0800 internal, signer/core: replace path.Join with filepath.Join (#29489) commit c170cc0ab0a1f60adcde80d0af8e3050ee19da93 Author: rjl493456442 <garyrong0905@gmail.com> Date: Mon Apr 8 21:48:37 2024 +0800 core/vm: reject contract creation if the storage is non-empty (#28912) This change implements EIP-7610, which rejects the contract deployment if the destination has non-empty storage. commit 3c75c64e6bbf64f842c6f725a595713262c2f8fe Author: seayyyy <163325936+seay404@users.noreply.github.com> Date: Mon Apr 8 19:02:56 2024 +0800 core: fix typo (#29438) commit c3465cb5ba94e8ee4153319416db9484406084ee Author: Sina M <1591639+s1na@users.noreply.github.com> Date: Mon Apr 8 13:01:22 2024 +0200 core: fix dev mode genesis difficulty (#29469) The dev mode is nowadays in Merge-mode from genesis, hence the difficulty of the first block should be zero. commit ed4bc7f27ba071403484240fa71b4878c4ca9756 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Mon Apr 8 18:59:17 2024 +0800 all: replace fmt.Errorf() with errors.New() if no param required (#29472) commit cfc7d06cc91122f44d09592ddc616fb189bc4ca4 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Mon Apr 8 18:58:37 2024 +0800 signer/core/apitypes: use slices.Contains (#29474) commit 0dc09da7db47de4a9a9eb6ea335e2e367fae6015 Author: imalasong <55082705+imalasong@users.noreply.github.com> Date: Mon Apr 8 17:29:49 2024 +0800 all: replace path.Join with filepath.Join (#29479) * core/rawdb: replace file.Join with filepath.Join Signed-off-by: xiaochangbai <704566072@qq.com> * internal/build: replace file.Join with filepath.Join Signed-off-by: xiaochangbai <704566072@qq.com> --------- Signed-off-by: xiaochangbai <704566072@qq.com> commit 7aafad2233b676b7beaf56e89f82360704d669d0 Author: Martin HS <martin@swende.se> Date: Sat Apr 6 12:22:55 2024 +0200 core/vm: better error-info for vm errors (#29354) commit 8876868bb831cef307d7e72c6848bd0943ba1e24 Author: Roberto Bayardo <roberto.bayardo@coinbase.com> Date: Sat Apr 6 03:17:41 2024 -0700 log: default JSON log handler should log all verbosity levels (#29471) Co-authored-by: lightclient <lightclient@protonmail.com> commit ccb76c01d7b1ce4d77d2bb309419cc78f42659ca Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Sat Apr 6 18:16:25 2024 +0800 eth/tracers: use slices.Contains (#29461) commit 74995bf8a169bb9d07333e56623ea039b8664710 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Sat Apr 6 18:05:06 2024 +0800 all: use slices.Contains (#29459) Co-authored-by: Felix Lange <fjl@twurst.com> commit cc348a601ee816d6c0e2c4d7246c810f3b61e798 Author: georgehao <haohongfan@gmail.com> Date: Sat Apr 6 17:09:30 2024 +0800 common/prque: fix godoc comments (#29460) Co-authored-by: Felix Lange <fjl@twurst.com> commit 4458905f261d5d9ba5fda3d664f9bb80346ab404 Author: Martin HS <martin@swende.se> Date: Fri Apr 5 21:01:39 2024 +0200 signer/core/apitypes: fix apitypes breakage due to bitrotted PR (#29470) commit 7ee9a6e89f59cee21b5852f5f6ffa2bcfc05a25f Author: Martin HS <martin@swende.se> Date: Fri Apr 5 19:29:44 2024 +0200 signer: implement blob txs sendtxargs, enable blobtx-signing (#28976) This change makes it possible to sign blob transactions commit 35fcf9c52b806d2a7eba0da4f65c97975200a2b2 Author: Felföldi Zsolt <zsfelfoldi@gmail.com> Date: Thu Apr 4 16:30:27 2024 +0200 beacon/types: enforce fork order based on known forks list (#29380) Co-authored-by: Felix Lange <fjl@twurst.com> commit 15ff066a24964ea16742420abecc7e4ae5e9bce0 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Thu Apr 4 21:52:38 2024 +0800 trie/utils: change Div+Mod to DivMod (#29413) * trie/utils: change Div+Mod to DivMod * trie/utils: gofmt commit e3bdd84e9881041e6004ebc3e78c1211d58ebe83 Author: Péter Szilágyi <peterke@gmail.com> Date: Thu Apr 4 16:51:10 2024 +0300 core/txpool: repair the limbo Billy too on unclean shutdowns (#29451) commit a851e39cbecf116ef2dc64f0b37b0300dc762931 Author: lmittmann <3458786+lmittmann@users.noreply.github.com> Date: Thu Apr 4 15:50:31 2024 +0200 core/types: use new atomic types in caches (#29411) * use generic atomic types in tx caches * use generic atomic types in block caches * eth/catalyst: avoid copying tx in test --------- Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com> commit 9cb8de87037be7c38343b2f84c534887e7525c5d Author: lightclient <14004106+lightclient@users.noreply.github.com> Date: Thu Apr 4 06:26:10 2024 -0400 internal/debug: convert legacy log level value in debug_verbosity (#29356) commit 9dfe728909bc7ff0709c69d3f090804d2516652c Author: cui <523516579@qq.com> Date: Thu Apr 4 18:24:49 2024 +0800 p2p/discover: using slices.Contains (#29395) commit 8bd03341689c992d633f3988b3a7fbc15aec75e6 Author: guangwu <guoguangwug@gmail.com> Date: Thu Apr 4 18:20:54 2024 +0800 crypto/signify: close tmp key file in test (#29444) commit 2e0c5e05ba355a722eb6eb9bc338de4949eee20d Author: cui <523516579@qq.com> Date: Thu Apr 4 18:19:48 2024 +0800 p2p/dnsdisc: using clear builtin func (#29418) Co-authored-by: Felix Lange <fjl@twurst.com> commit eea0acc54959df779189dbfc972578ae56ac4d33 Author: cui <523516579@qq.com> Date: Thu Apr 4 17:59:54 2024 +0800 log: using maps.Clone (#29392) commit 6b39e9236c278d9c4722505bb88a769fd21ca4b8 Author: cui <523516579@qq.com> Date: Thu Apr 4 17:58:44 2024 +0800 beacon/engine: using slices.Contains (#29396) commit 1f8f1377e62d2ca8aba04f0df7772ed665662bf7 Author: Marius Kjærstad <sandakersmann@users.noreply.github.com> Date: Thu Apr 4 11:00:27 2024 +0200 build: upgrade -dlgo version to Go 1.22.2 (#29448) commit 7bb3fb1481acbffd91afe19f802c29b1ae6ea60c Author: cui <523516579@qq.com> Date: Wed Apr 3 14:08:52 2024 +0800 eth: simplify peer counting logic (#29420) commit dfb3d46098520e90811c6ada3f8e142789c25832 Author: Ng Wei Han <47109095+weiihann@users.noreply.github.com> Date: Wed Apr 3 03:18:28 2024 +0800 p2p: add inbound and outbound peers metric (#29424) commit a83e57666d5a691883ab2890b63bda1b2c3e1c64 Author: cui <523516579@qq.com> Date: Wed Apr 3 03:17:34 2024 +0800 eth/fetcher: using slices.Contains (#29383) commit 12dcc162d05e87b6492c065458f2d7310b3cf791 Author: cui <523516579@qq.com> Date: Tue Apr 2 21:45:25 2024 +0800 common/lru: use clear builtin (#29399) commit ab6419ccd8b11e041e27f8865f59ab111a2c6161 Author: cui <523516579@qq.com> Date: Tue Apr 2 20:56:12 2024 +0800 core/state: use maps.Clone (#29365) core: using maps.Clone commit fe0bf325a68504292f910240f8da6243defffa71 Author: rjl493456442 <garyrong0905@gmail.com> Date: Tue Apr 2 20:25:06 2024 +0800 cmd/evm: reopen the statedb for dumping (#29437) commit 0bd03dbc5597175d79067270c0710604cba489cf Author: cui <523516579@qq.com> Date: Tue Apr 2 17:25:57 2024 +0800 eth/filter: using atomic.Pointer instead of atomic.Value (#29435) commit e63f992fed51d5a576ea2890cd7eb3000c9e6884 Author: Miles Chen <fearlesschenc@gmail.com> Date: Tue Apr 2 17:25:19 2024 +0800 rpc: fix ipc max path size (#29385) commit 31e63fcf66188504e0b1941059394cf5df49bc17 Author: cui <523516579@qq.com> Date: Tue Apr 2 16:47:15 2024 +0800 rlp: using maps.Clone (#29434) commit fde90443a4af0c8a0c0d7bdaf833a223de560cb3 Author: carehabit <165479941+carehabit@users.noreply.github.com> Date: Tue Apr 2 15:05:53 2024 +0800 log: replace the outdated link (#29412) commit 8c5576b1ac89473c7ec15c9b03d1ca02e9499dcc Author: Delweng <delweng@gmail.com> Date: Mon Apr 1 20:53:56 2024 +0800 eth/tracers: fix base fee and set blob fee in tests (#29376) Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> commit 6c9f7029823cac48291558aa0a76cbd653830f51 Author: cui <523516579@qq.com> Date: Mon Apr 1 11:45:56 2024 +0800 core/types: using maps.Clone (#29398) commit c39d00e316943fa613f10ceff262482ea3aa2c65 Author: cui <523516579@qq.com> Date: Mon Apr 1 11:42:50 2024 +0800 trie: using maps.Clone (#29419) commit a3829178af6cec64d6def9131b9340a3328cc4fc Author: Brandon Liu <lzqcn2000@126.com> Date: Fri Mar 29 00:35:40 2024 +0800 eth/tracers/js: consistent name for method receivers (#29375) commit 0183c7ad8225f82e2c23b9bc6329c19d7f0269c5 Author: cui <523516579@qq.com> Date: Thu Mar 28 21:09:21 2024 +0800 eth/tracers/logger: using maps.Equal (#29384) Co-authored-by: Felix Lange <fjl@twurst.com> commit 7481398a2471f52de277627cc473190f0c2569c8 Author: cui <523516579@qq.com> Date: Thu Mar 28 19:13:41 2024 +0800 core/state: using slices.Clone (#29366) commit 3754a6cc922f88f50ed0479cfb836676936384d3 Author: cui <523516579@qq.com> Date: Thu Mar 28 19:07:38 2024 +0800 p2p/dnsdisc: using maps.Copy (#29377) commit 3b77e0ff4bcce8c0c9f18f23625a6fe69d17bbed Author: rjl493456442 <garyrong0905@gmail.com> Date: Thu Mar 28 19:06:57 2024 +0800 core: remove unused code (#29381) commit 7aba6511b0cbe910a0db9d345487d2c6ef301e53 Author: cui <523516579@qq.com> Date: Thu Mar 28 19:06:44 2024 +0800 ethdb/dbtest: replace reflect.DeepEqual with slices.Equal (#29382) commit 767b00b0b514771a663f3362dd0310fc28d40c25 Author: Sina M <1591639+s1na@users.noreply.github.com> Date: Wed Mar 27 16:12:57 2024 +0100 t8ntool: add optional call frames to json logger (#29353) Adds a flag `--trace.callframes` to t8n which will log info when entering or exiting a call frame in addition to the execution steps. --------- Co-authored-by: Mario Vega <marioevz@gmail.com> commit fa5019de196274afd2426d300cab01d60b2a0c56 Author: crazeteam <164632007+crazeteam@users.noreply.github.com> Date: Wed Mar 27 20:16:29 2024 +0800 accounts/keystore: fix typos in comments (#29336) commit 8bb8f23bb25ab69cfb7065d7dbb3fd6e5f6227a8 Author: Pawan Dhananjay <pawandhananjay@gmail.com> Date: Wed Mar 27 17:45:57 2024 +0530 beacon/engine: Fix json param name in GetClientVersionV1 (#29351) Fix json param name commit 304879da20200f6912d241ccd471e140d3487093 Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Mar 27 09:35:33 2024 +0800 eth/protocols/snap: check storage root existence for hash scheme (#29341) commit da7469e5c44feec120555c8f697f75b94b2884bb Author: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Date: Tue Mar 26 21:25:41 2024 +0100 core: add an end-to-end verkle test (#29262) core: add a simple verkle test triedb, core: skip hash comparison in verkle core: remove legacy daoFork logic in verkle chain maker fix: nil pointer in tests triedb/pathdb: add blob hex core: less defensive Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Martin HS <martin@swende.se> Co-authored-by: Gary Rong <garyrong0905@gmail.com> commit 723b1e36ad6a9e998f06f74cc8b11d51635c6402 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Wed Mar 27 04:01:28 2024 +0800 all: fix mismatched names in comments (#29348) * all: fix mismatched names in comments * metrics: fix mismatched name in UpdateIfGt commit 58a3e2f1802eb7dd8e893a6a7be7f009edeeffd8 Author: jwasinger <j-wasinger@hotmail.com> Date: Tue Mar 26 07:21:39 2024 -0700 core/state: perform updates before deletions when mutating tries (#29201) This addresses an edge-case (detailed in the code comment) where the computation of the intermediate trie root would force the unnecessary resolution of a hash node. The change makes it so that when we process changes from a block, we first process trie-updates and afterwards process trie-deletions. commit 1dd898c24e85980a3ba9fcc203f00a3ea2f060d6 Author: Martin HS <martin@swende.se> Date: Tue Mar 26 15:04:15 2024 +0100 tests: fix panic via state test runner using json logger (#29349) * tests: fix panic via state test runner using json logger * tests: also invoke OnTxEnd commit f2a6ac17b255fe037bf528bc8368e61051cd4df4 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Tue Mar 26 19:26:44 2024 +0800 eth/catalyst: fix flaw in withdrawal-gathering in simulated beacon (#29344) return after reaching maxCount commit 738b5a586e329965539877434b695bb61015d4c7 Author: Matthieu Vachon <matt@streamingfast.io> Date: Tue Mar 26 00:01:13 2024 -0400 Removes some leftover `err` check (#29339) Before, `ToMessage` was returning both the resulting `Message` and an error while no error is returned now. Those error checks were probably leftover from the past. commit 100c0f47debad7924acefd48382bd799b67693cf Author: Felföldi Zsolt <zsfelfoldi@gmail.com> Date: Mon Mar 25 20:28:55 2024 +0100 beacon/blsync: fixed blsync command line params (#29335) commit eda9cb7b362b02c9c4550d77385997ed86981757 Author: Felix Lange <fjl@twurst.com> Date: Mon Mar 25 20:27:50 2024 +0100 beacon/light/api: improve handling of event stream setup failures (#29308) The StartHeadListener method will only be called once. So it can't just make one attempt to connect to the eventsource endpoint, it has to keep trying. Note that once the stream is established, the eventsource implementation itself will keep retrying. commit 5cea7a6230a6f070dd484aa6d883605f148445a4 Author: Roberto Bayardo <roberto.bayardo@coinbase.com> Date: Mon Mar 25 10:03:44 2024 -0700 ethclient/simulated: clean up Node resources when simulated backend is closed (#29316) commit 14cc967d1964d3366252193cadd4bfcb4c927ac1 Author: Martin HS <martin@swende.se> Date: Mon Mar 25 07:50:18 2024 +0100 all: remove dependency on golang.org/exp (#29314) This change includes a leftovers from https://github.com/ethereum/go-ethereum/pull/29307 - using the [new `slices` package](https://go.dev/doc/go1.21#slices) and - using the [new `cmp.Ordered`](https://go.dev/doc/go1.21#cmp) instead of exp `constraints.Ordered` commit ae470044878f15beb67eb7e66c117c9ad48f3a7b Author: deterclosed <164524498+deterclosed@users.noreply.github.com> Date: Mon Mar 25 10:16:44 2024 +0800 eth: fix typo (#29320) commit 6f1fb0c29ff25318e688c15581d0c28dcefb75ce Author: Nathan <Nathan.l@nodereal.io> Date: Sun Mar 24 20:51:34 2024 +0800 metrics/influxdb: skip float64-precision-dependent tests on arm64 (#29047) metrics/influxdb: fix failed cases caused by float64 precision on arm64 commit 064f37d6f67a012eea0bf8d410346fb1684004b4 Author: Sina M <1591639+s1na@users.noreply.github.com> Date: Fri Mar 22 18:53:53 2024 +0100 eth/tracers: live chain tracing with hooks (#29189) Here we add a Go API for running tracing plugins within the main block import process. As an advanced user of geth, you can now create a Go file in eth/tracers/live/, and within that file register your custom tracer implementation. Then recompile geth and select your tracer on the command line. Hooks defined in the tracer will run whenever a block is processed. The hook system is defined in package core/tracing. It uses a struct with callbacks, instead of requiring an interface, for several reasons: - We plan to keep this API stable long-term. The core/tracing hook API does not depend on on deep geth internals. - There are a lot of hooks, and tracers will only need some of them. Using a struct allows you to implement only the hooks you want to actually use. All existing tracers in eth/tracers/native have been rewritten to use the new hook system. This change breaks compatibility with the vm.EVMLogger interface that we used to have. If you are a user of vm.EVMLogger, please migrate to core/tracing, and sorry for breaking your stuff. But we just couldn't have both the old and new tracing APIs coexist in the EVM. --------- Co-authored-by: Matthieu Vachon <matthieu.o.vachon@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Martin HS <martin@swende.se> commit 38eb8b3e20bf237a78fa57e84fa63c2d05a44635 Author: George Ma <164313692+availhang@users.noreply.github.com> Date: Fri Mar 22 20:29:12 2024 +0800 all: fix docstrings (#29311) commit d9bde37ac3a5a9569a0c0a35f8c872932d640802 Author: Martin HS <martin@swende.se> Date: Fri Mar 22 13:17:59 2024 +0100 log: use native log/slog instead of golang/exp (#29302) commit 6490d9897ab00290d188b1893d1874e977fb4c66 Author: rjl493456442 <garyrong0905@gmail.com> Date: Fri Mar 22 20:12:10 2024 +0800 cmd, triedb: implement history inspection (#29267) This pull request introduces a database tool for inspecting the state history. It can be used for either account history or storage slot history, within a specific block range. The state output format can be chosen either with - the "rlp-encoded" values (those inserted into the merkle trie) - the "rlp-decoded" value (the raw state value) The latter one needs --raw flag. commit f46fe62c5d1d25ce0e9869ecbaf0e5722d2bc2f5 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Fri Mar 22 04:38:24 2024 -0700 triedb/hashdb: Avoid setting db.cleans on Close (#29309) commit 14eb8967be7acc54c5dc9a416151ac45c01251b6 Author: Martin HS <martin@swende.se> Date: Thu Mar 21 13:50:13 2024 +0100 all: use min/max/clear from go1.21 (#29307) commit bca6c407098fefc757c263ae2da6aeff719e17ca Author: Felix Lange <fjl@twurst.com> Date: Wed Mar 20 19:22:44 2024 +0100 beacon/blsync: support for deneb fork (#29180) This adds support for the Deneb beacon chain fork, and fork handling in general, to the beacon chain light client implementation. Co-authored-by: Zsolt Felfoldi <zsfelfoldi@gmail.com> commit 04bf1c802ffe9dfc34c34b3e666ee15e96b4a203 Author: Martin HS <martin@swende.se> Date: Wed Mar 20 15:22:52 2024 +0100 eth/protocols/snap, internal/testlog: fix dataraces (#29301) commit 8f7fbdfedcbaca2a2bffb00badc75c03d58052ec Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Wed Mar 20 14:58:47 2024 +0100 core: refactor consensus interface (#29283) This PR modifies the consensus interface to wrap the body fields. commit 0444388c746f99186e086f8ea733ea45e91918ac Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Wed Mar 20 21:51:05 2024 +0800 core/txpool/blobpool: calculate log1.125 faster (#29300) commit 78c102dec5f1c7b5256c466df4421b4818bfe0e6 Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Mar 20 20:11:30 2024 +0800 core: skip the check the statefulness of head block in repair (#29245) commit 22ac46cbdbd0601d2c59a74bb29fb0ceb34dddaa Author: imalasong <55082705+imalasong@users.noreply.github.com> Date: Wed Mar 20 20:09:46 2024 +0800 Makefile: update PHONY directive (#29296) commit 9a7e6ce6f593d1284512032d5757a85a15e6d636 Author: Martin HS <martin@swende.se> Date: Wed Mar 20 10:38:30 2024 +0100 cmd/evm: fix flag-mismatch from #29290 (#29298) commit de08f3d62552531f3fb2fc3a64a4bfdb962900eb Author: Martin HS <martin@swende.se> Date: Wed Mar 20 09:12:58 2024 +0100 cmd/evm: make staterunner always output stateroot to stderr (#29290) This changes makes it so that when `evm statetest` executes, regardless of whether `--json` is specified or not, the stateroot is printed on `stderr` as a `jsonl` line. This enables speedier execution of testcases in goevmlab, in cases where full execution op-by-op is not required. commit 0ceac8d00e3067b6bb7ddc79670383295ddf7d6d Author: georgehao <haohongfan@gmail.com> Date: Wed Mar 20 15:51:45 2024 +0800 metrics: fix docstrings (#29279) commit 45b88abbde92eab99bab6ac1e55aa88bccccfe80 Author: miles <66052478+miles-six@users.noreply.github.com> Date: Wed Mar 20 15:49:38 2024 +0800 all: fix typos (#29288) commit 6f929a0762be92130588779a8535ed0e3fc58d87 Author: zgfzgf <48779939+zgfzgf@users.noreply.github.com> Date: Wed Mar 20 15:46:50 2024 +0800 core/asm: minor code-clarification (#29293) commit 4c1b57856f0f5ebccb6edb83ab755ab114500078 Author: buddho <galaxystroller@gmail.com> Date: Tue Mar 19 22:23:55 2024 +0800 miner: modify header before checking time-based fields (#29242) The Prepare-method of consensus engine might modify the time-field in a header, so it should be called prior to checks that rely on it commit eda9c7e36f120a3e4feb3dfa9472084e88e35054 Author: Tien Nguyen <116023870+htiennv@users.noreply.github.com> Date: Tue Mar 19 20:05:31 2024 +0700 accounts/abi/bind: check invalid chainID first (#29275) commit 6b3d4d068ac720de1c2edab7d1e1a1311811d747 Author: bitcoin-lightning <153181187+AtomicInnovation321@users.noreply.github.com> Date: Tue Mar 19 21:05:06 2024 +0800 beacon/light/sync: fix typo in comment (#29256) commit ac6060a4c61b99743173c8c88ea1f8f68f6cdbfc Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Tue Mar 19 18:25:30 2024 +0800 log: replace tmp with bytes.Buffer.AvailableBuffer (#29287) commit 15eb9773f9b99c29f3cd17be4e4bbd1bf1b48bb7 Author: rjl493456442 <garyrong0905@gmail.com> Date: Tue Mar 19 10:50:08 2024 +0800 triedb/pathdb: improve tests (#29278) commit ab49f228ad6f37ba78be66b34aa5fee740245f57 Author: Martin HS <martin@swende.se> Date: Mon Mar 18 17:36:50 2024 +0100 all: update to go version 1.22.1 (#28946) Since Go 1.22 has deprecated certain elliptic curve operations, this PR removes references to the affected functions and replaces them with a custom implementation in package crypto. This causes backwards-incompatible changes in some places. --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Felix Lange <fjl@twurst.com> commit c6119247271220ce89e76e1b1b2eaeaaa8fbd9d1 Author: Martin HS <martin@swende.se> Date: Mon Mar 18 08:13:55 2024 +0100 go.mod: update protobuf (#29270) commit ba2dd9385c2a51134e520083dc732787a813b107 Author: SanYe <kumakichi@users.noreply.github.com> Date: Fri Mar 15 17:46:22 2024 +0800 accounts/abi/bind: remove unused err set and check (#29269) accounts/abi: remove unused err set and check commit 40cac1d0e2cb37e769c3928cc477efb41124bb60 Author: Martin HS <martin@swende.se> Date: Fri Mar 15 10:44:41 2024 +0100 eth/catalyst: prettier output on bad new payloads (#29259) When we receive a bad NewPayload, we currently emit a lot of data to the logging facilities. This PR makes it so we print less data. commit 95715fdb0317dc7d6ebbec702fe78257380c95a1 Author: shivhg <shivhg@gmail.com> Date: Fri Mar 15 14:37:47 2024 +0530 eth/downloader, graphql: fix typos (#29243) commit cffb7c8604d299ac21e0a9714205cc7b52faa501 Author: Haotian <51777534+tmelhao@users.noreply.github.com> Date: Fri Mar 15 16:14:31 2024 +0800 params: use the same variable name as EIP-4788 (#29195) In https://eips.ethereum.org/EIPS/eip-4788 the name `BEACON_ROOTS_ADDRESS` is used. This change makes geth use the same variable name to avoid confusion. commit d28adb61bf8445f9de58612155c308e5ac3b197a Author: John Xu <dyxushuai@gmail.com> Date: Thu Mar 14 21:38:11 2024 +0800 cmd/emv/internal/t8ntool: fix shadowing of `excessBlobGas` (#29263) fix(t8n): unexpected `excessBlobGas` shadowed commit 20d3e0ac06ef2ad2f5f6500402edc5b6f0bf5b7c Author: Ng Wei Han <47109095+weiihann@users.noreply.github.com> Date: Thu Mar 14 17:32:49 2024 +0800 cmd/devp2p: fix decoding of raw RLP ENR attributes (#29257) commit 3c26ffeb2968907f68d41faab757dacdcb280941 Author: Haotian <51777534+tmelhao@users.noreply.github.com> Date: Thu Mar 14 07:26:46 2024 +0800 eth/catalyst: remove error return in delayPayloadImport (#29043) Co-authored-by: tmelhao <tmelhao@gmail.com> commit 57308beecf7040391aee6c3102587063501f6825 Author: Bin <49082129+songzhibin97@users.noreply.github.com> Date: Thu Mar 14 07:25:42 2024 +0800 go.mod: update golang.org/x/crypto from v0.17.0 to v0.21.0 (#29228) commit f3d18d64bf4c026740ee6c8ae8949a8c19391b49 Author: Martin HS <martin@swende.se> Date: Wed Mar 13 18:12:23 2024 +0100 tests, appveyor: only execute one in four permutations on CI (#29220) tests, appveyor: only execute one in four permutations when flag -short is used Also enable -short flag on all appveyor builds (also ubuntu) commit c170fa277cbf2a9faf9f35665f1ba8f34f94062a Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Mar 13 19:39:30 2024 +0800 core: improve chain rewinding mechanism (#29196) * core: improve chain rewinding mechanism * core: address comment * core: periodically print progress log * core: address comments * core: fix comment * core: fix rewinding in path * core: fix beyondRoot condition * core: polish code * core: polish code * core: extend code comment * core: stop rewinding if chain is gapped or genesis is reached * core: fix broken tests commit b80643b7370075262fd6dfad7ae8aa77710e2ef1 Author: Justin Dhillon <justin.singh.dhillon@gmail.com> Date: Tue Mar 12 23:54:40 2024 -0700 accounts/usbwallet, common/bitutil: fix broken links in docs (#29078) fixes some links in documentation commit d5bacfa4def558a4c7b261c1a9fbfdbfc295e491 Author: Martin HS <martin@swende.se> Date: Wed Mar 13 07:51:46 2024 +0100 crypto/kz4844: pass blobs by ref (#29050) This change makes use of the following underlying changes to the kzg-libraries in order to avoid passing large things on the stack: - c-kzg: https://github.com/ethereum/c-kzg-4844/pull/393 and - go-kzg: https://github.com/crate-crypto/go-kzg-4844/pull/63 commit eff424cc302152f3914e3f9c8b49efe92e33353f Author: Sina M <1591639+s1na@users.noreply.github.com> Date: Wed Mar 13 07:40:02 2024 +0100 eth/tracers: fix concurrency issue for JS-tracing a block (#29238) This change fixes a concurrency-issue where JS-tracers were accessing the block-ctx GetHash function in a in parallel, which is not safe. commit 758fce71fab5289e3af711b1fa21a541c77cc435 Author: Felix Lange <fjl@twurst.com> Date: Tue Mar 12 19:23:24 2024 +0100 p2p: fix race in dialScheduler (#29235) Co-authored-by: Stefan <stefan@starflinger.eu> commit 6c76b813df6d53b86fac17471e9a31afd20c481e Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Tue Mar 12 14:29:35 2024 +0100 miner: add additional log (#29193) Adds a debug level log if the payload building failed for whatever reason commit 4bd55a064ccc804127de09397273d16966fe8a37 Author: Aaron Chen <aaronchen.lisp@gmail.com> Date: Tue Mar 12 20:05:31 2024 +0800 common/math: copy result in Exp (#29233) common/math: does not change base parameter commit 99bbbc0277e34fc3a31512a345ba20874ae98e18 Author: Shiming Zhang <wzshiming@hotmail.com> Date: Tue Mar 12 19:12:37 2024 +0800 internal/build, rpc: add missing HTTP response body Close() calls (#29223) Co-authored-by: Felix Lange <fjl@twurst.com> commit 89cefe240fd22b01e413786e18ad35263c93a61f Author: Bin <49082129+songzhibin97@users.noreply.github.com> Date: Tue Mar 12 17:00:34 2024 +0800 cmd: use package filepath over path for file system operations (#29227) Package filepath implements utility routines for manipulating filename paths in a way compatible with the target operating system-defined file paths. Package path implements utility routines for manipulating slash-separated paths. The path package should only be used for paths separated by forward slashes, such as the paths in URLs commit 4e1116f9c513961b62dff146a7cce069fe7a36b0 Author: San Ye <kumakichi@users.noreply.github.com> Date: Tue Mar 12 16:49:53 2024 +0800 crypto/bn256/cloudflare: fix noescape-directive (#29222) commit ebf9e11af2ff701d0961623e817d37b421b96802 Author: guangwu <guoguangwu@magic-shield.com> Date: Mon Mar 11 18:17:16 2024 +0800 beacon/light/request: fix typos (#29216) commit fa4ade8ecb4e37687b464fdab6986c01cc1e50c2 Author: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Date: Mon Mar 11 11:05:48 2024 +0100 core: fix deprecation comment for GenesisAccount (#29218) core: fix deprecation comment commit 00c21128ef62be54bef798f3220f79ae2297be66 Author: Lee Bousfield <ljbousfield@gmail.com> Date: Mon Mar 11 05:05:17 2024 -0500 core/txpool/blobpool: return ErrAlreadyKnown for duplicate txs (#29210) Signed-off-by: Lee Bousfield <ljbousfield@gmail.com> commit b393ad8d29fe002fe6c0329a09d7715b00030c79 Author: Péter Szilágyi <peterke@gmail.com> Date: Mon Mar 11 10:06:57 2024 +0200 cmd, core, metrics: always report expensive metrics (#29191) * cmd, core, metrics: always report expensive metrics * core, metrics: report block processing metrics as resetting timer * metrics: update reporter tests commit 3dc549b3d75af790e78ef2d7f63a947efb9b0e95 Author: Kero <keroroxx520@gmail.com> Date: Mon Mar 11 03:01:26 2024 +0800 p2p/simulations/adapters: fix error messages in TestTCPPipeBidirections (#29207) commit e31709db6570e302557a9bccd681034ea0dcc246 Author: Haotian <51777534+tmelhao@users.noreply.github.com> Date: Fri Mar 8 19:15:52 2024 +0800 console: fix the wrong error msg of datadir testcase (#29183) commit d35c8f0c25d3b5781e016252625b582c9553601a Author: colin <102356659+colinlyguo@users.noreply.github.com> Date: Fri Mar 8 19:13:46 2024 +0800 ethclient/gethclient: add blob transaction fields in toCallArg (#29198) commit c41105ce80f12f60ec4bf6c65c4c59c6bf4a86e7 Author: Sebastian Stammler <seb@oplabs.co> Date: Fri Mar 8 00:01:31 2024 +0100 log: add Handler getter to Logger interface (#28793) log: Add Handler getter to Logger interface commit cd490608e344e388edd7ef3dd323968d706ccf8c Author: hyhnet <cyrusyun@qq.com> Date: Fri Mar 8 05:56:19 2024 +0800 all: fix typos in comments (#29186) commit 3bebabbd036d4f550e32bb20a92bf7da6e6a2797 Author: cuinix <65650185+cuinix@users.noreply.github.com> Date: Fri Mar 8 05:25:08 2024 +0800 accounts: remove redundant string conversion (#29184) commit aadcb886753079d419f966a3bc990f708f8d1c3b Author: Felföldi Zsolt <zsfelfoldi@gmail.com> Date: Wed Mar 6 17:50:22 2024 +0100 cmd/blsync, beacon/light: beacon chain light client (#28822) Here we add a beacon chain light client for use by geth. Geth can now be configured to run against a beacon chain API endpoint, without pointing a CL to it. To set this up, use the `--beacon.api` flag. Information provided by the beacon chain is verified, i.e. geth does not blindly trust the beacon API endpoint in this mode. The root of trust are the beacon chain 'sync committees'. The configured beacon API endpoint must provide light client data. At this time, only Lodestar and Nimbus provide the necessary APIs. There is also a standalone tool, cmd/blsync, which uses the beacon chain light client to drive any EL implementation via its engine API. --------- Co-authored-by: Felix Lange <fjl@twurst.com> commit d8e0807da22eb922539d15b0d5d01ccdd58b1267 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Wed Mar 6 13:45:03 2024 +0100 miner: refactor the miner, make the pending block on demand (#28623) * miner: untangle miner * miner: use common.hash instead of *types.header * cmd/geth: deprecate --mine * eth: get rid of most miner api * console: get rid of coinbase in welcome message * miner/stress: get rid of the miner stress test * eth: get rid of miner.setEtherbase * ethstats: remove miner and hashrate flags * ethstats: remove miner and hashrate flags * cmd: rename pendingBlockProducer to miner.pending.feeRecipient flag * miner: use pendingFeeRecipient instead of etherbase * miner: add mutex to protect the pending block * miner: add mutex to protect the pending block * eth: get rid of etherbase mentions * miner: no need to lock the coinbase * eth, miner: fix linter --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com> commit 6e379b6fc776668c9a7db6d5b014d0dd89d7118d Author: Delweng <delweng@gmail.com> Date: Wed Mar 6 20:36:12 2024 +0800 eth/tracers: prestate tracer add blob fee (#29168) * eth/tracers: prestate balance add blob fee Signed-off-by: jsvisa <delweng@gmail.com> * eth/tracers: prestate test support blob tx Signed-off-by: jsvisa <delweng@gmail.com> * eth/tracers: add prestate blob tx test Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com> commit a90fe84971183aa0b6c40d71c6586ae3f2eda4c8 Author: Undefinedor <wanghao@imwh.net> Date: Wed Mar 6 18:55:44 2024 +0800 accounts: remove deprecated function NewPlaintextKeyStore (#29171) commit e73f55365c458c5185a493935b65dd96bacf6933 Author: Martin HS <martin@swende.se> Date: Wed Mar 6 11:31:50 2024 +0100 accounts/usbwallet: update hid library (#29176) commit a000acb61114c2a3a74c065f2e61b4d6bca3ae46 Author: Andrei Kostakov <bps@dzen.ws> Date: Wed Mar 6 11:53:12 2024 +0200 rpc: add more test cases for arg types (#29006) commit 899bb88a4ba19af2d8fe4874561a9d55355acf48 Author: Martin HS <martin@swende.se> Date: Wed Mar 6 10:32:17 2024 +0100 accounts/usbwallet: revert #28945 (#29175) commit 588c5480fd1f355a39d3f52a5507ab9d0da334c9 Author: Tom <45168162+tomdever@users.noreply.github.com> Date: Wed Mar 6 13:23:35 2024 +0800 internal/ethapi: delete needless error check (#29127) commit 66e1a6ef496e001abc7ae7433282251a557deb2c Author: Devon Bear <itsdevbear@berachain.com> Date: Tue Mar 5 09:15:02 2024 -0500 go.mod: bump pebble db to official release (#29038) bump pebble commit f4d53133f6e4b13f0dbcfef3bc45e9650d863b73 Author: Péter Szilágyi <peterke@gmail.com> Date: Tue Mar 5 16:13:28 2024 +0200 consensus, cmd, core, eth: remove support for non-merge mode of operation (#29169) * eth: drop support for forward sync triggers and head block packets * consensus, eth: enforce always merged network * eth: fix tx looper startup and shutdown * cmd, core: fix some tests * core: remove notion of future blocks * core, eth: drop unused methods and types commit 9a0fa8093ca5f7b896c3f7e849f7ca532d24e2a6 Author: Marius van der Wijden <m.vanderwijden@live.de> Date: Tue Mar 5 14:52:44 2024 +0100 node: remove test which doesn't do a lot (#29159) * node: fix test if directory already exists * node: remove test commit 9e129efd7b43242fb5e605065713c27d615e753d Author: zhiqiangxu <652732310@qq.com> Date: Tue Mar 5 21:48:27 2024 +0800 core: remove useless assignments (#29065) commit a970295956d602c348dccce034712c14aedce5e0 Author: cui <523516579@qq.com> Date: Tue Mar 5 21:45:17 2024 +0800 rlp: using unsafe.Slice instead of SliceHeader (#29067) Co-authored-by: Felix Lange <fjl@twurst.com> commit a6d6e8ac410170eb1085b9e7b0388b1c67f95548 Author: Undefinedor <wanghao@imwh.net> Date: Tue Mar 5 21:44:23 2024 +0800 rpc: remove deprecated method "Notifier.Closed" (#29162) commit dfa6c5e9c80e0965d0476909afc26e87aa199e6a Author: Delweng <delweng@gmail.com> Date: Tue Mar 5 21:37:26 2024 +0800 internal/jsre: format blob fields from hexdecimal to int (#29166) * internal/jsre: format receipt.{blobGasPrice,blobGasUsed} to int Signed-off-by: jsvisa <delweng@gmail.com> * internal/jsre: format tx.maxFeePerBlobGas to int Signed-off-by: jsvisa <delweng@gmail.com> * internal/jsre: format blob* in block Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com> commit 96bf23f1ea95d29a32abe8fe2992b86e892b6c4c Author: Martin HS <martin@swende.se> Date: Tue Mar 5 14:32:47 2024 +0100 accounts/usbwallet: use updated hid (only) library (#28945) * accounts/usbwallet: use updated hid (only) library * deps: update karalabe/hid commit 7b81cf6362b3bb52762b823edf2a31bbbed4aa84 Author: rjl493456442 <garyrong0905@gmail.com> Date: Tue Mar 5 21:31:55 2024 +0800 core/state, trie/triedb/pathdb: remove storage incomplete flag (#28940) As SELF-DESTRUCT opcode is disabled in the cancun fork(unless the account is created within the same transaction, nothing to delete in this case). The account will only be deleted in the following cases: - The account is created within the same transaction. In this case the original storage was empty. - The account is empty(zero nonce, zero balance, zero code) and is touched within the transaction. Fortunately this kind of accounts are not-existent on ethereum-mainnet. All in all, after cancun, we are pretty sure there is no large contract deletion and we don't need this mechanism for oom protection. commit e199319fd680aa4b135147f0480549a1c7d95350 Author: buddho <galaxystroller@gmail.com> Date: Tue Mar 5 17:47:56 2024 +0800 rlp: remove a moot todo (#29154) commit d89d7ebdec27d8c8fed217767e2f17b09b5460a0 Author: zhiqiangxu <652732310@qq.com> Date: Tue Mar 5 16:47:58 2024 +0800 core: initialize `gasRemaining` with `=` instead of `+=` (#29149) initialize gasRemaining with = instead of += commit 9b3ceb2137df125dd0f6957a362e9f08d6c41b66 Author: Vie <yangchenzhong@gmail.com> Date: Tue Mar 5 15:33:52 2024 +0800 core/types: reuse signtx (#29152) * core/types: reuse signtx * core/types: inline signtx commit 5d5b384efd0acabe4d808c46fce9700114d2046f Author: Domino Valdano <dominoplural@gmail.com> Date: Mon Mar 4 12:58:25 2024 -0800 .mailmap: remove invalid email address (#29163) commit 19607d1a10d37542ba13ab9db48cf4e501715cce Author: Andrei Silviu Dragnea <andreidragnea.dev@gmail.com> Date: Mon Mar 4 20:21:43 2024 +0100 eth/tracers: Fix prestateTracer pre nonce on contract creation (#29099) The prestateTracer was reporting an inaccurate nonce for the contract being created in post EIP-158 transactions. Correct nonce is 0, due to the issue nonce was being reported as 1. commit ca473b81cbe4a96cde4e8424c49b15ab304787bb Author: rjl493456442 <garyrong0905@gmail.com> Date: Mon Mar 4 22:25:53 2024 +0800 core: use finalized block as the chain freeze indicator (#28683) * core: use finalized block as the chain freeze indicator * core/rawdb: use max(finality, head-90k) as chain freezing threshold * core/rawdb: fix tests * core/rawdb: fix lint * core/rawdb: address comments from peter * core/rawdb: fix typo commit a97d622588c2b71557c6222b95d487f51b46bd78 Author: Felix Lange <fjl@twurst.com> Date: Mon Mar 4 14:07:41 2024 +0100 cmd/devp2p: fix commandHasFlag (#29091) It got broken in some update of the cli library, and thus bootnodes weren't being configured automatically for some of the discovery commands. commit 35cebc16877c4cfbf48b883ab3bfa02b9100a87a Author: psogv0308 <psogv0308@gmail.com> Date: Mon Mar 4 19:03:53 2024 +0900 triedb/pathdb: changed the test code to check for verifying state (#29150) Co-authored-by: this-is-iron <iron@superblock.co> commit 679a27a2b36d4f86e6b49c49c0d51c47a7ef6145 Author: buddho <galaxystroller@gmail.com> Date: Mon Mar 4 17:31:18 2024 +0800 all: use EmptyUncleHash, EmptyCodeHash instead of raw value (#29134) commit 5a1e8a6547d6606c7ff1e3f3841fbb1c9f205282 Author: cui <523516579@qq.com> Date: Mon Mar 4 17:30:15 2024 +0800 core: delete unused ErrMaxInitCodeSizeExceeded (#29062) commit b408b3e5fece3524bf7721ac8dd8d9a898f571a8 Author: yzb <flyingyzb@gmail.com> Date: Mon Mar 4 17:24:24 2024 +0800 accounts/abi: delete duplicate error check (#29136) commit a732ad036488e3d5db33928f0155ffd66e08c08d Author: yzb <flyingyzb@gmail.com> Date: Mon Mar 4 17:16:05 2024 +0800 p2p: remove unused argument 'flags' (#29132) commit 00905f7dc406cfb67f64cd74113777044fb886d8 Author: Undefinedor <wanghao@imwh.net> Date: Sun Mar 3 04:42:50 2024 +0800 all: remove redundant import aliases (#29144) commit 0b1438c3df5da5551e89dddc683d65f4d48ad3d6 Author: Péter Szilágyi <peterke@gmail.com> Date: Sat Mar 2 22:39:22 2024 +0200 eth: make transaction propagation paths in the network deterministic (#29034) * eth: make transaction propagation paths in the network deterministic * eth: avoid potential division by 0 * eth: make tx propagation dependent on local node id too * eth: fix review comments commit 0a2f33946b95989e8ce36e72a88138adceab6a23 Author: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Date: Thu Feb 29 13:17:32 2024 +0100 eth/catalyst: update simulated beacon for cancun (#28829) * eth/catalyst: update simulated beacon for cancun * validate blob hashes * compute hashes from commitment * fix beacon root and payload version * check commitment conversion * fix random attr * flip dev to cancun commit 865e1e9f577f4fa804d0246f82cbcedc27db9bf6 Author: Péter Szilágyi <peterke@gmail.com> Date: Thu Feb 29 12:40:59 2024 +0200 cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme (#29108) * cmd/utils, core/rawdb, triedb/pathdb: flip hash to path scheme * graphql: run tests in hash mode as the chain maker needs it commit db4cf6916606e07d908af44e405257925dd9265e Author: yzb <335357057@qq.com> Date: Thu Feb 29 17:56:46 2024 +0800 all: replace fmt.Errorf() with errors.New() if no param required (#29126) replace-fmt-errorf Co-authored-by: yzb@example.cn <yzb@example.cn> commit 28d55218f7d793c184f4220a16a60e309caa70af Author: Ng Wei Han <47109095+weiihann@users.noreply.github.com> Date: Thu Feb 29 17:56:17 2024 +0800 cmd/geth: parseDumpConfig should not return closed db (#29100) * cmd: parseDumpConfig should not return closed db * fix lint commit dbc27a199f411fc620eeb8589fd75a144f83ee8c Author: cui fliter <imcusg@gmail.com> Date: Thu Feb 29 17:29:06 2024 +0800 all: fix function names in docs (#29128) Signed-off-by: cui fliter <imcusg@gmail.com> commit 1883438964a7a4c68cee1de619526e8bc1e68b30 Author: lightclient <14004106+lightclient@users.noreply.github.com> Date: Wed Feb 28 11:59:16 2024 -0700 eth/catalyst: return invalid payload attributes instead of invalid parms for bad fcu payload (#29115) commit 9986a69c25452ff0e7ce323446b215e2d0075185 Author: buddho <galaxystroller@gmail.com> Date: Thu Feb 29 01:38:21 2024 +0800 internal/ethapi: pass in accesslist in test (#29089) Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> commit 5bae14f9df498243091078fc8d3ea6ab99669087 Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Feb 28 20:40:28 2024 +0800 triedb/pathdb: fix panic in recoverable (#29107) * triedb/pathdb: fix panic in recoverable * triedb/pathdb: add todo * triedb/pathdb: rename * triedb/pathdb: rename commit 49623bd4697f5b333ae977968186d0717f918927 Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Feb 28 20:23:52 2024 +0800 core, triedb/pathdb: calculate the size for batch pre-allocation (#29106) * core, triedb/pathdb: calculate the size for batch pre-allocation * triedb/pathdb: address comment commit 170fcd80c6f5d07d7d839e895765de193c34a8b3 Author: Péter Szilágyi <peterke@gmail.com> Date: Wed Feb 28 10:01:52 2024 +0200 params: being major version bump cycle commit 02d77c98f9e1efaf3fede313b0e9183dc54562b6 Author: cui <523516579@qq.com> Date: Wed Feb 28 15:25:12 2024 +0800 core: using math.MaxUint64 instead of 0xffffffffffffffff (#29094) commit 57d2b552c74dbd03b9909e6b8cd7b3de1f8b40e9 Author: Péter Szilágyi <peterke@gmail.com> Date: Tue Feb 27 13:53:30 2024 +0200 params: begin v1.13.15 cycle commit 9038ba69428a6ecada1f2acace6981854482748b Author: Péter Szilágyi <peterke@gmail.com> Date: Tue Feb 27 13:50:30 2024 +0200 params: release Geth v1.13.14 commit 51b479e56459d663a12f95fd8eaba82716c0d5ce Author: Roberto Bayardo <roberto.bayardo@coinbase.com> Date: Tue Feb 27 03:27:50 2024 -0800 core/txpool: elevate the 'already reserved' error into a constant (#29095) declare the 'already reserved' error in errors.go commit 5a0f468f8cb15b939bd85445d33c614a36942a8e Author: Andrei Silviu Dragnea <andreisilviudragnea@gmail.com> Date: Tue Feb 27 10:29:12 2024 +0100 eth/tracers: Fix callTracer logs on onlyTopCall == true (#29068) commit 45a272c7b96cb260528bbc2e31d657488f97c4b0 Author: Delweng <delweng@gmail.com> Date: Tue Feb 27 00:34:45 2024 +0800 core/txpool: no need to log loud rotate if no local txs (#29083) * core/txpool: no need to run rotate if no local txs Signed-off-by: jsvisa <delweng@gmail.com> * Revert "core/txpool: no need to run rotate if no local txs" This reverts commit 17fab173883168c586d57ca9c05dfcbd9e7831b4. Signed-off-by: jsvisa <delweng@gmail.com> * use Debug if todo is empty Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com> commit 63aaac81007ad46b208570c17cae78b7f60931d4 Author: Péter Szilágyi <peterke@gmail.com> Date: Mon Feb 26 14:27:56 2024 +0200 core/txpool/blobpool: reduce default database cap for rollout (#29090) xcore/txpool/blobpool: reduce default database cap for rollout commit c1f59b98f6b0351339767d71953eb4eb5d19c496 Author: cui <523516579@qq.com> Date: Mon Feb 26 20:22:13 2024 +0800 eth/catalyst: remove variable in tx conversion loop (#29076) commit 821d70240d191ff451a813287a377466337a3cee Author: Justin Dhillon <justin.singh.dhillon@gmail.com> Date: Mon Feb 26 02:03:59 2024 -0800 cmd/clef: add spaces in README.md table (#29077) Add space after links in so they are clickable in vscode. commit 8bca93e82c59d04f23b0237292d17fe728f20a5b Author: maskpp <maskpp266@gmail.com> Date: Mon Feb 26 18:02:18 2024 +0800 internal/ethapi: pass blob hashes to gas estimation (#29085) commit edffacca8f97d23298636e225d477818e58eafe7 Author: cui <523516579@qq.com> Date: Mon Feb 26 17:59:03 2024 +0800 eth/catalyst: enable some commented-out testcases (#29073) commit 26724fc2aaf0cf8711c25ca664c0451f68d977fe Author: Qt <golang.chen@gmail.com> Date: Mon Feb 26 17:25:35 2024 +0800 p2p, log, rpc: use errors.New to replace fmt.Errorf with no parameters (#29074) commit 32d4d6e6160432be1cb9780a43253deda7708ced Author: Roberto Bayardo <roberto.bayardo@coinbase.com> Date: Mon Feb 26 01:06:52 2024 -0800 core/txpool: reject blob txs with blob fee cap below the minimum (#29081) * make blobpool reject blob transactions with fee below the minimum * core/txpool: some minot nitpick polishes and unified error formats * core/txpool: do less big.Int constructions with the min blob cap --------- Co-authored-by: Péter Szilágyi <peterke@gmail.com> commit 93c541ad563124e81d125c7ebe78938175229b2e Author: Haotian <51777534+tmelhao@users.noreply.github.com> Date: Fri Feb 23 16:57:47 2024 +0800 eth/catalyst: fix wrong error message of payloadV2 after cancun (#29049) * eth/catalyst: the same error format Signed-off-by: tmelhao <tmelhao@gmail.com> * eth/catalyst: wrong error message for payloadV2 post-cancun Signed-off-by: tmelhao <tmelhao@gmail.com> * eth/catalyst: parentBeaconBlockRoot -> parentBlockBeaconRoot Signed-off-by: tmelhao <tmelhao@gmail.com> * apply commit review Signed-off-by: tmelhao <tmelhao@gmail.com> --------- Signed-off-by: tmelhao <tmelhao@gmail.com> Co-authored-by: tmelhao <tmelhao@gmail.com> commit b87b9b45331f87fb1da379c5f17a81ebc3738c6e Author: colin <102356659+colinlyguo@users.noreply.github.com> Date: Thu Feb 22 23:35:23 2024 +0800 internal/ethapi:fix zero rpc gas cap in eth_createAccessList (#28846) This PR enhances eth_createAccessList RPC call to support scenarios where the node is launched with an unlimited gas cap (--rpc.gascap 0). The eth_createAccessList RPC call returns failure if user doesn't explicitly set a gas limit. commit e47a7c22c40b9037049cb63d74eb1216aabdee60 Author: ArtificialPB <matej.berger@hotmail.com> Date: Thu Feb 22 14:39:22 2024 +0100 internal/ethapi: use overriden baseFee for gasPrice (#29051) eth_call and debug_traceCall allow users to override various block fields, among them base fee. However the overriden base fee was not considered for computing the effective gas price of that message, and instead base fee of the base block was used. This has been fixed in this commit. commit b590cae89232299d54aac8aada88c66d00c5b34c Author: Felix Lange <fjl@twurst.com> Date: Wed Feb 21 15:49:50 2024 +0100 params: begin v1.13.14 release cycle commit 3b4ede74443a15db27fddbb803a6b0cc4180ca75 Author: Felix Lange <fjl@twurst.com> Date: Wed Feb 21 15:44:02 2024 +0100 params: release go-ethereum v1.13.13 stable commit b47cf8fe1de4f97ce38417d8136a58812734a7a9 Author: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Date: Wed Feb 21 12:46:32 2024 +0100 internal/ethapi: fix defaults for blob fields (#29037) Co-authored-by: Martin HS <martin@swende.se> commit b9ca38b7358dbf7e236c624043bbab789a8d0389 Author: colin <102356659+colinlyguo@users.noreply.github.com> Date: Wed Feb 21 16:00:01 2024 +0800 core/txpool: fix typo (#29036) * fix typos * address comments commit 79e340fb1276cd5f0bbdc3825f90090488e3b978 Author: Haotian <51777534+tmelhao@users.noreply.github.com> Date: Wed Feb 21 15:59:21 2024 +0800 params: add cancun upgrade banner (#29042) params: add cancun banner Signed-off-by: tmelhao <tmelhao@gmail.com> Co-authored-by: tmelhao <tmelhao@gmail.com> commit bba3fa9af9709ce6615d994edac7043e064fda0d Author: buddho <galaxystroller@gmail.com> Date: Tue Feb 20 19:42:48 2024 +0800 core,eth,internal: fix typo (#29024) commit 7f5e96dc6c0d70f793a6a41c059c5dd660357964 Author: buddho <galaxystroller@gmail.com> Date: Tue Feb 20 18:08:56 2024 +0800 core/txpool: fix typo (#29031) commit f4852b8ddc8bef962d34210a4f7774b95767e421 Author: Péter Szilágyi <peterke@gmail.com> Date: Tue Feb 20 11:37:23 2024 +0200 core/txpool, eth, miner: retrieve plain and blob txs separately (#29026) * core/txpool, eth, miner: retrieve plain and blob txs separately * core/txpool: fix typo, no farming * miner: farm all the typos Co-authored-by: Martin HS <martin@swende.se> --------- Co-authored-by: Martin HS <martin@swende.se> commit ac0ff044606a663eeb47ef60ed5506f8427530…

…#28623) * miner: untangle miner * miner: use common.hash instead of *types.header * cmd/geth: deprecate --mine * eth: get rid of most miner api * console: get rid of coinbase in welcome message * miner/stress: get rid of the miner stress test * eth: get rid of miner.setEtherbase * ethstats: remove miner and hashrate flags * ethstats: remove miner and hashrate flags * cmd: rename pendingBlockProducer to miner.pending.feeRecipient flag * miner: use pendingFeeRecipient instead of etherbase * miner: add mutex to protect the pending block * miner: add mutex to protect the pending block * eth: get rid of etherbase mentions * miner: no need to lock the coinbase * eth, miner: fix linter --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com>

MariusVanDerWijden requested review from gballet, karalabe, holiman and rjl493456442 as code owners November 29, 2023 11:13

MariusVanDerWijden changed the title ~~miner: refactor the miner, make the pending block on demand~~ WIP miner: refactor the miner, make the pending block on demand Nov 29, 2023

holiman reviewed Nov 30, 2023

View reviewed changes

miner/builder.go Outdated Show resolved Hide resolved

MariusVanDerWijden force-pushed the miner-stuff branch from b287ded to 30c2529 Compare November 30, 2023 08:27

MariusVanDerWijden commented Dec 4, 2023

View reviewed changes

cmd/utils/flags.go Outdated Show resolved Hide resolved

MariusVanDerWijden commented Dec 4, 2023

View reviewed changes

miner/miner.go Outdated Show resolved Hide resolved

MariusVanDerWijden changed the title ~~WIP miner: refactor the miner, make the pending block on demand~~ miner: refactor the miner, make the pending block on demand Dec 4, 2023

lightclient reviewed Dec 7, 2023

View reviewed changes

MariusVanDerWijden force-pushed the miner-stuff branch from fa4ed3d to aa568d4 Compare December 19, 2023 10:53

MariusVanDerWijden force-pushed the miner-stuff branch from aa568d4 to c0a8bf4 Compare January 9, 2024 17:06

s1na mentioned this pull request Jan 10, 2024

internal/ethapi: avoid using pending for defaults #28784

Merged

holiman reviewed Jan 11, 2024

View reviewed changes

miner/miner.go Outdated Show resolved Hide resolved

rjl493456442 reviewed Jan 16, 2024

View reviewed changes

miner/miner.go Outdated Show resolved Hide resolved

rjl493456442 added the status:triage label Jan 16, 2024

lightclient reviewed Jan 16, 2024

View reviewed changes

rjl493456442 reviewed Jan 22, 2024

View reviewed changes

holiman added status:marinating PR hasn't been open long enough to get merged and removed status:triage labels Jan 30, 2024

MariusVanDerWijden commented Feb 6, 2024

View reviewed changes

eth/api_miner.go Show resolved Hide resolved

MariusVanDerWijden force-pushed the miner-stuff branch 3 times, most recently from 205c995 to 1282507 Compare February 13, 2024 10:00

MariusVanDerWijden force-pushed the miner-stuff branch from db03ea3 to 9ba1d40 Compare February 14, 2024 09:24

holiman added the status:triage label Feb 15, 2024

karalabe reviewed Mar 6, 2024

View reviewed changes

eth/filters/filter_system.go Show resolved Hide resolved

karalabe reviewed Mar 6, 2024

View reviewed changes

ethstats/ethstats.go Show resolved Hide resolved

karalabe reviewed Mar 6, 2024

View reviewed changes

internal/web3ext/web3ext.go Outdated Show resolved Hide resolved

eth: get rid of miner.setEtherbase

4f248a8

karalabe reviewed Mar 6, 2024

View reviewed changes

miner/miner.go Show resolved Hide resolved

MariusVanDerWijden added 6 commits March 6, 2024 11:57

ethstats: remove miner and hashrate flags

d7f3978

ethstats: remove miner and hashrate flags

6b21155

cmd: rename pendingBlockProducer to miner.pending.feeRecipient flag

2bd5c5f

miner: use pendingFeeRecipient instead of etherbase

4cf7e95

miner: add mutex to protect the pending block

0115bb7

miner: add mutex to protect the pending block

a81a192

karalabe reviewed Mar 6, 2024

View reviewed changes

eth/backend.go Outdated Show resolved Hide resolved

eth: get rid of etherbase mentions

81276b3

karalabe reviewed Mar 6, 2024

View reviewed changes

miner/pending.go Outdated Show resolved Hide resolved

miner: no need to lock the coinbase

4a11409

karalabe approved these changes Mar 6, 2024

View reviewed changes

eth, miner: fix linter

3a1eb62

karalabe merged commit d8e0807 into ethereum:master Mar 6, 2024
2 of 3 checks passed

karalabe added this to the 1.14.0 milestone Mar 6, 2024

MariusVanDerWijden mentioned this pull request Apr 3, 2024

Pending Log Subscription emits logs at extremely slow rate ( roughly 1 pending transaction per second ) #29415

Closed

BrewTestBot mentioned this pull request Apr 24, 2024

ethereum 1.14.0 Homebrew/homebrew-core#169942

Merged

tersec mentioned this pull request May 25, 2024

rm Clique consensus method support and Goerli network status-im/nimbus-eth1#2219

Merged

egonspace mentioned this pull request Jun 13, 2024

An eth_estimate request uses stale state in a mining node. wemixarchive/go-wemix#109

Closed

FletcherMan mentioned this pull request Jun 17, 2024

Miner: refactor miner, make pending block on demand morph-l2/go-ethereum#100

Merged

13 tasks

buddh0 mentioned this pull request Oct 16, 2024

Merge v1.14.0 3 buddh0/bsc#44

Merged

islishude mentioned this pull request Oct 29, 2024

miner: remove tcount adding after miner.commitTransaction ethereum-optimism/op-geth#419

Merged

buddh0 mentioned this pull request Nov 8, 2024

upstream: Prague code merge [v1.13.15, v1.14.11] bnb-chain/bsc#2753

Closed

buddh0 mentioned this pull request Nov 22, 2024

upstream: Prague code merge [v1.13.15, v1.14.11] bnb-chain/bsc#2761

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

miner: refactor the miner, make the pending block on demand #28623

miner: refactor the miner, make the pending block on demand #28623

MariusVanDerWijden commented Nov 29, 2023 •

edited by holiman

Loading

lightclient Dec 7, 2023

lightclient Dec 7, 2023

holiman left a comment

lightclient left a comment •

edited

Loading

rjl493456442 Jan 22, 2024

MariusVanDerWijden commented Feb 13, 2024

karalabe left a comment

miner: refactor the miner, make the pending block on demand #28623

miner: refactor the miner, make the pending block on demand #28623

Conversation

MariusVanDerWijden commented Nov 29, 2023 • edited by holiman Loading

lightclient Dec 7, 2023

Choose a reason for hiding this comment

lightclient Dec 7, 2023

Choose a reason for hiding this comment

holiman left a comment

Choose a reason for hiding this comment

lightclient left a comment • edited Loading

Choose a reason for hiding this comment

rjl493456442 Jan 22, 2024

Choose a reason for hiding this comment

MariusVanDerWijden commented Feb 13, 2024

karalabe left a comment

Choose a reason for hiding this comment

MariusVanDerWijden commented Nov 29, 2023 •

edited by holiman

Loading

lightclient left a comment •

edited

Loading