accounts: properly close account manager and usb wallets #28710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, when interacting both via
geth
andclef
, that shutting down the process and trying to work with usb hardware wallets again, most often failed. I had to unplug the device and plug it back again for it to work.It turns out that the account manager did not call
Close
on the wallets that it was managing.Further,
clef
did not even bother to close the account manager.This PR fixes both problems.