cmd/evm: Fix blob-gas-used on invalid transactions #28734
Conversation
There was a problem hiding this comment.
Is there an issue here where if the tx is applied successfully, but we later find out that it is technically invalid due to exceeding the blob gas limit, that the state is not reset?
I think you will need to add statedb.RevertToSnapshot(snapshot) above the err assignment to correct this.
|
Yep I think it's like @lightclient said. Previously we filtered out the blob transactions before applying them. Now we apply them and potentially leave the statedb in a weird state. We should make sure to explicitly reset the statedb in order to prevent any unwanted modification of the state by failed transactions. The fix itself looks good to me, you're right previously we incremented the blob gas used even if the transaction failed while applying the message. |
marioevz
force-pushed
the
evm-t8n-fix-blob-gas-used
branch
from
3f95120
to
168b9da
Compare
|
Thanks for the review @lightclient, I've simplified the PR and fixed the issue, let me know if this looks ok. |
…8734) cmd/evm: fixes the blob gas calculation if a transaction is invalid
…8734) cmd/evm: fixes the blob gas calculation if a transaction is invalid
Moves the block's blob-gas-used increment to the same place as the normal gas so that, in the case of failed transactions, neither gas type usage is incremented.