eth: fix potential hang in waitSnapExtension #28744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niuxiaojie81
requested review from
karalabe,
holiman and
rjl493456442
as code owners
|
The fix refers to this PR, but the blocking scenario is completely different from it |
|
I appreciate the clear description. The fix seems weird though, and could be improved to not use a timeout. How about we just add a |
|
@fjl Yes, your modification suggestion is more reasonable. I have updated it. Please review it. |
holiman
reviewed
Jan 12, 2024
holiman
reviewed
Jan 12, 2024
fjl
changed the title
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
This should fix a rare hang in waitSnapExtension during shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When geth is shut down gracefully, the running eth protocol blocks in waitSnapExtension
Steps to reproduce:
runEthPeerfunction. At this time, theincHandlersfunction returns true, waits for snap extension, and blocks in thewaitSnapExtension.runSnapExtensionfunction. At this time, theincHandlersfunction returns false and will not enter theregisterSnapExtension.runEthPeerfunction has been blocked inwaitSnapExtension, and the ETH handler cannot exit normally.