-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracer: use proper base fee in tests #28775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks good catch. I did have a question tho.
eth/tracers/internal/tracetest/testdata/prestate_tracer_with_diff_mode/create_failed.json
Outdated
Show resolved
Hide resolved
8a9c9ad
to
c5ca0b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approved pending green tests!
The failing tests seems to be flaky, no caused by this PR |
356b49a
to
ce36f4d
Compare
ce36f4d
to
69d9cd4
Compare
I'm not sure why CI doesn't turn green. There seem to be some flaky tests, especially |
Don't worry about it. And no need to force-push to trigger it, we can rerun the ones that fail |
Re-running the failed tests 🤞 sometimes we have to do this a couple of times to get the green check |
In the tracing tests, the base fee was generally set to nil. This commit changes this to pass the proper base instead, and fixes the few tests which become broken by the change.
While working on another issue, I found that in the tracing tests the base fee is generally set to
nil
(see https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/internal/tracetest/prestate_test.go#L120). Changing this to pass the proper base fee works for most tests, butTestPrestateWithDiffModeTracer
runs into problems in thecreate_failed.json
test case.Here the base fee is 51088069741, and the transactions fee limit is set to 112855938170. The transactions tip cap is 1500000000. This leads to a gas price of 112855938170 when the base fee is not set, but 52588069741 when the base fee is set.
The difference between those two values is 60267868429, multiplied by the gas limit of the transaction (176545) this makes up a balance difference of 10639990831797805, which is changes in the test file.
Resolves #28773