Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon/light/request: simple request framework #28906

Closed
wants to merge 3 commits into from

Conversation

zsfelfoldi
Copy link
Contributor

This PR implements a general-purpose framework for sync mechanisms requesting data from multiple servers. It is intended to be used primarily by the beacon chain light client but might be used for other purposes too as it does nothing specific to the beacon chain. It implements timeouts, very simple rate limits and server selection, basically abstracting away the multiple server logic from the actual sync processes.

Co-authored-by: Martin HS <martin@swende.se>
@holiman
Copy link
Contributor

holiman commented Feb 15, 2024

Doesn't compile?

?   	github.com/ethereum/go-ethereum/beacon/engine	[no test files]
ok  	github.com/ethereum/go-ethereum/beacon/light	0.185s
# github.com/ethereum/go-ethereum/beacon/light/request [github.com/ethereum/go-ethereum/beacon/light/request.test]
beacon\light\request\scheduler.go:220:46: syntax error: unexpected bool in argument list; possibly missing comma or )
FAIL	github.com/ethereum/go-ethereum/beacon/light/request [build failed]
?   	github.com/ethereum/go-ethereum/beacon/merkle	[no test files]
?   	github.com/ethereum/go-ethereum/beacon/params	[no test files]

@zsfelfoldi
Copy link
Contributor Author

Doesn't compile?

Indeed, last commit had a missing bracket, fixed.

@fjl
Copy link
Contributor

fjl commented Mar 6, 2024

Included in #28822, which was merged.

@fjl fjl closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants