Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: move genesis alloc types to core/types #29003

Merged
merged 5 commits into from
Feb 16, 2024
Merged

core: move genesis alloc types to core/types #29003

merged 5 commits into from
Feb 16, 2024

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Feb 16, 2024

This is in preparation for a pending refactor of the #27629. It is backwards-compatible.

holiman
holiman approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but funny that you mention "it's backwards-compatible" -- since it moves a publically exported type to a different package, it obviously cannot be fully backwards compatible. But I think it's fine with a little bit of fallout :)

@fjl
Copy link
Contributor

fjl commented Feb 16, 2024

It is fully backwards-compatible because of the type alias type GenesisAlloc = types.GenesisAlloc. Anywhere new type is used, you can still also use the old name. But it will show you a deprecation warning in the IDE.

@fjl
Copy link
Contributor

fjl commented Feb 16, 2024

External code will not be affected by this move. But we decided to change all of our internal uses of the type as well.

@fjl fjl changed the title core: mv genesis alloc to core/types core: move genesis alloc types to core/types Feb 16, 2024
@fjl fjl added this to the 1.13.13 milestone Feb 16, 2024
@fjl fjl merged commit 95741b1 into ethereum:master Feb 16, 2024
2 of 3 checks passed
@dnhn dnhn mentioned this pull request Feb 21, 2024
Merged
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
@s1na @fjl @jorgemmsilva
core: move genesis alloc types to core/types (ethereum#29003)
147649c 
We want to use these types in public user-facing APIs, so they shouldn't be in core.

Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.13
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @fjl @holiman