Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: using math.MaxUint64 instead of 0xffffffffffffffff #29022

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

cuiweixie
Copy link
Contributor

No description provided.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why though?

@cuiweixie
Copy link
Contributor Author

Why though?

when I am reading the code, i have count f for 16times to make sure i am right about that It does is maxuint64. so I send this pr to make it more readable for reading the code.

@rjl493456442
Copy link
Member

I think the change is good, math.MaxUint64 is definitely more readable than 0xffffffffffffffff

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit 5d98479 into ethereum:master Feb 19, 2024
2 of 3 checks passed
@holiman holiman added this to the 1.13.13 milestone Feb 19, 2024
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants