miner: lower default min miner tip from 1 gwei to 0.001 gwei #29895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
May 31, 2024
|
lgtm.
|
This was referenced Jun 5, 2024
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
stwiname
pushed a commit
to subquery/data-node-go-ethereum
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of a long debate as to what the default minimum miner tip expectation of Geth should be. It's important to highlight here that this is just a CLI flag that miners can change, but still people felt strongly that the default should be more reasonable (#29771).
The 1 gwei was originally meant as an opportunity cost for doing more computation on the block + propagating a larger block, which could have someone beat the miner to producing a block. With PoS, there's no opportunity cost wrt someone producing a better block, so it makes sense to reduce the minimum needed price.
Whilst in theory we could also just completely remove it, I feel that miners should still be rewarded something for adding transactions to their blocks, and with 0.001 gwei we're already under the rounding error category. I don't really see a reason to go below this point in the current climate. Maybe in the future if something changes, this can be revisited.
cc @dataalways