beacon/light: fix shutdown issues #29946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
force-pushed
the
blsync-fix-crash
branch
from
dd150bd
to
b292b4f
Compare
fjl
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes shutdown/server disconnection issues in the beacon light syncer:
stream.Close().beacon/light/requestdid not handle server disconnection properly. If an event callback arrived after unsubscribing from server events (shutdown occured while a request was pending) the server called the removed (nil) callback function. Also, the unsubscription from the parent was called while the server mutex was locked, which was both unnecessary and wrong because it broke the normal locking order (Scheduler->serverWithLimits->serverWithTimeout->ApiServer) sometimes causing a deadlock during shutdown.