Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/math: fix out of bounds access in json unmarshalling #30014

Merged
merged 3 commits into from
Jun 17, 2024
Merged

common/math: fix out of bounds access in json unmarshalling #30014

merged 3 commits into from
Jun 17, 2024

Conversation

decanus
Copy link
Contributor

@decanus decanus commented Jun 17, 2024

Fixes a potential panic if len(input) == 1

input = input[1 : len(input)-1]

namiloh
namiloh approved these changes Jun 17, 2024
View reviewed changes
Copy link

@namiloh namiloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@holiman holiman changed the title fix potential panic common/math: fix out of bounds access in json unmarshalling Jun 17, 2024
@holiman holiman added this to the 1.14.6 milestone Jun 17, 2024
@fjl fjl merged commit d866449 into ethereum:master Jun 17, 2024
3 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@namiloh namiloh namiloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.6
Development

Successfully merging this pull request may close these issues.
5 participants
@decanus @holiman @MariusVanDerWijden @namiloh @fjl