Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi/bind: add accessList support to base bond contract #30195

Merged

Conversation

ysh0566
Copy link
Contributor

@ysh0566 ysh0566 commented Jul 20, 2024

Adding the correct accessList parameter when calling a contract can reduce gas consumption. However, the current version only allows adding the accessList manually when constructing the transaction. This PR can provide convenience for saving gas.

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, yes adding the optional accesslist to the transactOpts makes sense to me. It wasn't added in london, but in the berlin hardfork iirc. But that doesn't really matter imo

@lightclient lightclient merged commit 67b8137 into ethereum:master Aug 1, 2024
2 checks passed
@lightclient lightclient added this to the 1.14.8 milestone Aug 1, 2024
leeren pushed a commit to storyprotocol/story-geth that referenced this pull request Aug 16, 2024
…reum#30195)

Adding the correct accessList parameter when calling a contract can
reduce gas consumption. However, the current version only allows adding
the accessList manually when constructing the transaction. This PR can
provide convenience for saving gas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants