Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/tracers/logger: Encode only if condition permit #30365

Closed
wants to merge 1 commit into from
Closed

eth/tracers/logger: Encode only if condition permit #30365

wants to merge 1 commit into from

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Aug 28, 2024 •
edited
Loading

  • Do encoding if !failed || l.err == vm.ErrExecutionReverted is true.
  • Change to use hex.Encode because it runs faster than fmt.Sprintf function.

@mask-pp mask-pp requested a review from s1na as a code owner August 28, 2024 14:31
@holiman
Copy link
Contributor

holiman commented Sep 16, 2024

I don't see any reason to change this -- it's not such a hot loop.

@holiman holiman closed this Sep 16, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1na s1na Awaiting requested review from s1na s1na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mask-pp @holiman