core/state: add flag for inidicating the existence of storage #30405
+99
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Sep 13, 2024
Comment on lines
+216
to
+219
| // Note, the slot is regarded as existent even they are marked as deleted, | ||
| // specifically the value is [32]byte{}, as there is no delete notion in verkle | ||
| // world anymore and the deletions will be translated to a special marker | ||
| // writing ultimately. |
There was a problem hiding this comment.
If zeroes / deleted counts as existent, in verkle but not in mpt, then I think the high-level description of this operation (in the docstring) needs to be clarified. What are the semantics that we're supposed to deliver in this method?
Comment on lines
+396
to
+397
| // StateExists returns the flag indicating whether the storage slot specified by | ||
| // address and storage key is existent. |
There was a problem hiding this comment.
here too, what does 'existent' mean, in mpt and verkle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP