Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p/netutil: unittests for addrutil #30439

Merged
merged 5 commits into from
Nov 11, 2024
Merged

p2p/netutil: unittests for addrutil #30439

merged 5 commits into from
Nov 11, 2024
+140 −0

Conversation

tianyeyouyou
Copy link
Contributor

add unit tests for p2p/addrutil

holiman
holiman reviewed Nov 9, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me, aside from a couple of small things.

p2p/netutil/addrutil_test.go Outdated Show resolved Hide resolved
p2p/netutil/addrutil_test.go Show resolved Hide resolved
@holiman holiman changed the title test(p2p/addrutil): add unit tests p2p/netutil: unittests for addrutil Nov 9, 2024
holiman
holiman approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.14.12 milestone Nov 9, 2024
@MariusVanDerWijden
Copy link
Member

Could you rebase it on top of current master?
There was a failing unit test, which was fixed on master at some point

MariusVanDerWijden
MariusVanDerWijden approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

holiman
holiman approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit ae83912 into ethereum:master Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@holiman holiman holiman approved these changes

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees

@fjl fjl

Labels
None yet
Projects
None yet
Milestone
1.14.12
Development

Successfully merging this pull request may close these issues.
4 participants
@tianyeyouyou @MariusVanDerWijden @holiman @fjl