cmd/evm: benchmarking via statetest command + filter by name, index and fork
#30442
+117
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
requested review from
holiman,
MariusVanDerWijden and
lightclient
as code owners
holiman
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Checked to see if there was any noticeable slowdown.
Master:
$ time yes ~/go/src/github.com/holiman/goevmlab/examples/sstore_static/sstore_test.json | head -n 1000 | go run ./cmd/evm/ statetest 2>/dev/null 1>/dev/null
real 0m3.389s
user 0m3.688s
sys 0m1.008s
This PR
$ time yes ~/go/src/github.com/holiman/goevmlab/examples/sstore_static/sstore_test.json | head -n 1000 | go run ./cmd/evm/ statetest 2>/dev/null 1>/dev/null
real 0m3.409s
user 0m3.927s
sys 0m1.042s
So 👍
Just some minor nits, otherwise lgtm
holiman
changed the title
--bench flag support to include statetest subcommand. introduce test name, fork, index filtering flags for state test subcommand.statetest command + filter by name, index and fork
holiman
reviewed
Sep 24, 2024
Comment on lines
+187
to
+207
| } else if len(matchingTests) != 1 { | ||
| return fmt.Errorf("can only benchmark single state test case (more than one matching params)") | ||
| } | ||
| var gasUsed uint64 | ||
| result := testing.Benchmark(func(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| test := matchingTests[0] | ||
| _, _, gasUsed, _ = test.test.RunNoVerify(test.st, cfg, false, rawdb.HashScheme) | ||
| } | ||
| }) | ||
| var stats execStats | ||
| // Get the average execution time from the benchmarking result. | ||
| // There are other useful stats here that could be reported. | ||
| stats.time = time.Duration(result.NsPerOp()) | ||
| stats.allocs = result.AllocsPerOp() | ||
| stats.bytesAllocated = result.AllocedBytesPerOp() | ||
| fmt.Fprintf(os.Stderr, `EVM gas used: %d | ||
| execution time: %v | ||
| allocations: %d | ||
| allocated bytes: %d | ||
| `, gasUsed, stats.time, stats.allocs, stats.bytesAllocated) |
There was a problem hiding this comment.
I would move this into its own function and do something like this
if bench {
runBenchmark()
}
return nil
which makes it a big cleaner imo
MariusVanDerWijden
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
evm statetest --benchis specified, benchmark the execution similarly toevm run. It will explicitly error if there is more than one matched subtest to be executed (newstatetestflags are added to filter which tests are ran).Breaks the state test runner API. But I figure that we are the only consumers of this API, so it's not a big problem?