-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installing-geth.md: Include Gentoo installation instructions #30450
Merged
+16
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this maintained by you personally, @SamWilsn ?
IMO we should integrate it into our CI pipeline if we have it here -- no offense meant to you, but we should not rely on specific individuals pushing packages years into the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am the current maintainer, yes. It has been in the Gentoo repository for much longer than that, however. Note that this is the official Gentoo repository, and is not something like a PPA or the AUR.
I'd be happy to investigate automation if there's a chance of merging it. Essentially this would entail copying a file, updating the URL, running a build, and opening a pull request.
How is this implemented for Arch Linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't maintain the ArchLinux package, it's done by a community member.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.
Well as far as automation goes, I believe it would go in
ci.go
? The process for 1.14.9 would look something like:gentoo/gentoo
.net-p2p/go-ethereum/go-ethereum-1.14.8.ebuild
tonet-p2p/go-ethereum/go-ethereum-1.14.9.ebuild
.LONG_VERSION
).USE=devtools
. I imagine this would use docker.Should I go ahead and build all of that, or can I continue to do it by hand (with the assumption it'll get removed from the documentation if the package gets out of date)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to automate this in our pipeline.
ci.go
is the build script that creates binaries. We do have some automation in there for Debian/Ubuntu as well. But it's just about generating packaging files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see three options for moving this PR forward:
How would you like to proceed?