-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trie: parallelize committer #30461
base: master
Are you sure you want to change the base?
trie: parallelize committer #30461
Conversation
Without benchmarks to support it, these kind of changes aren’t “evaluable”.
We’re tried in the past and it’s extremely hard to make such a change, it
will mostly probably be slower rather than faster unfortunately.
…On Wed, 18 Sep 2024 at 18:58, steven ***@***.***> wrote:
@stevemilk <https://github.com/stevemilk> requested your review on: #30461
<#30461> trie: parallize
committer as a code owner.
—
Reply to this email directly, view it on GitHub
<#30461 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7UGJHXQ3NOXEIAS5ED23ZXGPJNAVCNFSM6AAAAABOOATFDCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGMYTAMJYGE2TONQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Got it, will do benchmark test then. |
Benchmark results on my linux machine
|
I also looked at those charts a bit. I'm a bit confused. Where is |
@holiman Yes, i just deployed it on a ongoing benchmark pairs (new release vs last release) to have a quick test. |
True, we need to update them |
Make node commit to be able to run in parallel, like node hash in
hasher.go
.