Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state: enable partial-functional reader (snapshot integration pt 3) #30650

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

rjl493456442
Copy link
Member

It's a pull request based on #30643

In this pull request, the partial functional state reader is enabled if legacy snapshot
is not enabled
. The tracked flat states in pathdb will be used to serve the state
retrievals, as the second implementation to fasten the state access.

This pull request should be a noop change in normal cases.

@rjl493456442 rjl493456442 force-pushed the snapshot-integration-p3 branch from 8242f88 to dab10e1 Compare October 23, 2024 06:09
@holiman holiman changed the title core/state: enable partial-functional reader core/state: enable partial-functional reader (snapshot integration pt 3) Oct 23, 2024
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the last commit, that looks good to me.
Will it be enabled on archive nodes that run without a snapshot?

@rjl493456442 rjl493456442 force-pushed the snapshot-integration-p3 branch 2 times, most recently from 46c0141 to 1f693ca Compare November 30, 2024 07:53
@rjl493456442 rjl493456442 force-pushed the snapshot-integration-p3 branch from 1f693ca to 1438459 Compare November 30, 2024 07:56
@rjl493456442
Copy link
Member Author

It will be enabled on path-based nodes when snapshots are explicitly disabled.

State access will first be served by these in-memory layers, falling back to the trie if the state is not found. (State access in the persistent store is not yet supported.)

Copy link

@namiloh namiloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjl493456442 rjl493456442 added this to the 1.14.13 milestone Dec 10, 2024
@rjl493456442 rjl493456442 merged commit a91dcf3 into ethereum:master Dec 10, 2024
3 checks passed
@fjl fjl modified the milestones: 1.14.13, 1.15.0 Jan 23, 2025
tokeyg pushed a commit to tokeyg/go-ethereum that referenced this pull request Feb 6, 2025
… 3) (ethereum#30650)

It's a pull request based on ethereum#30643

In this pull request, the partial functional state reader is enabled if **legacy snapshot
is not enabled**. The tracked flat states in pathdb will be used to serve the state
retrievals, as the second implementation to fasten the state access.

This pull request should be a noop change in normal cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants