-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/state: enable partial-functional reader (snapshot integration pt 3) #30650
core/state: enable partial-functional reader (snapshot integration pt 3) #30650
Conversation
8242f88
to
dab10e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at the last commit, that looks good to me.
Will it be enabled on archive nodes that run without a snapshot?
46c0141
to
1f693ca
Compare
1f693ca
to
1438459
Compare
It will be enabled on path-based nodes when snapshots are explicitly disabled. State access will first be served by these in-memory layers, falling back to the trie if the state is not found. (State access in the persistent store is not yet supported.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… 3) (ethereum#30650) It's a pull request based on ethereum#30643 In this pull request, the partial functional state reader is enabled if **legacy snapshot is not enabled**. The tracked flat states in pathdb will be used to serve the state retrievals, as the second implementation to fasten the state access. This pull request should be a noop change in normal cases.
It's a pull request based on #30643
In this pull request, the partial functional state reader is enabled if legacy snapshot
is not enabled. The tracked flat states in pathdb will be used to serve the state
retrievals, as the second implementation to fasten the state access.
This pull request should be a noop change in normal cases.