beacon/blsync: remove cli dependencies #30720
Merged
+254
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
requested review from
fjl,
holiman,
karalabe,
gballet and
rjl493456442
as code owners
zsfelfoldi
force-pushed
the
remove-cli-dep
branch
from
9cd8a12 to
26c5ca9
Compare
| default: | ||
| if !customConfig { | ||
| config.ChainConfig = *bparams.MainnetLightConfig | ||
| } |
There was a problem hiding this comment.
I think we should log here, that a fully custom config is being used
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
This PR moves chain config related code (config file processing, fork logic, network defaults) from `beacon/types` and `beacon/blsync` into `beacon/params` while the command line flag logic of the chain config is moved into `cmd/utils`, thereby removing the cli dependencies from package `beacon` and its sub-packages.
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
This PR moves chain config related code (config file processing, fork logic, network defaults) from `beacon/types` and `beacon/blsync` into `beacon/params` while the command line flag logic of the chain config is moved into `cmd/utils`, thereby removing the cli dependencies from package `beacon` and its sub-packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves chain config related code (config file processing, fork logic, network defaults) from
beacon/typesandbeacon/blsyncintobeacon/paramswhile the command line flag logic of the chain config is moved intocmd/utils, thereby removing the cli dependencies from packagebeaconand its sub-packages.