Empty Call response should return 0x instead of 0x00. Closes #739 #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference #739 |
obscuren
added a commit
that referenced
this pull request
Apr 23, 2015
Empty Call response should return 0x instead of 0x00. Closes #739
jpeletier
added a commit
to epiclabs-io/go-ethereum
that referenced
this pull request
Jul 18, 2018
) * cmd/swarm: add implicit subcommand help (fix ethereum#786) * cmd/swarm: moved implicit help to a recursive func
jpeletier
added a commit
to epiclabs-io/go-ethereum
that referenced
this pull request
Jul 23, 2018
) * cmd/swarm: add implicit subcommand help (fix ethereum#786) * cmd/swarm: moved implicit help to a recursive func
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
) * cmd/swarm: add implicit subcommand help (fix ethereum#786) * cmd/swarm: moved implicit help to a recursive func
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent returns a hexstring converted with common.FromHex(), which does not adhere to hexdata spec for empty result. This is a hack to handle this specific case.
A better fix would be to alter XEth to return the bytes instead of a hexified string or to make hexdata a proper type and return that. Currently, it only exists in RPC package.