Mutable memory #318
Mutable memory #318
Conversation
|
BTW, the previous failure, |
|
yeah, the tests now fail quite often and I believe this is all caused by the new z3 |
There was a problem hiding this comment.
Aside from the unfortunate proliferation of type parameters this is surprisingly clean. I had expected integrating St to be more involved tbh. Really nice work <3.
I wonder if it's possible to add some type aliases or newtypes or something to tidy up some of the clutter?
src/EVM.hs
Outdated
| if srcOffset' >= fromIntegral (BS.length b) then | ||
| BS.replicate (fromIntegral size') 0 | ||
| else | ||
| BS.take (fromIntegral size') $ | ||
| padRight (fromIntegral size') $ | ||
| BS.drop (fromIntegral srcOffset') b |
There was a problem hiding this comment.
can we use tryFrom / into here?
arcz
force-pushed
the
mutable-mem
branch
6 times, most recently
from
46cf074
to
b49c7c5
Compare
arcz
force-pushed
the
mutable-mem
branch
3 times, most recently
from
d4f63b7
to
f565d5b
Compare
|
What's left to do here? I have a bunch of larger changes I wanna make and I'd like to get this in first to avoid more merge work for you @arcz |
|
I think it's ready, I'm rebasing it on main atm |
Description
Closes #292.
Checklist