[DRAFT] Fixing prank: no longer override the sender on lower frames #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #608
msooseth
changed the title
|
@elopez could you maybe review? Maybe it'd be useful to add more tests in |
elopez
reviewed
Nov 28, 2024
elopez
reviewed
Nov 28, 2024
| let from = fromMaybe vm.state.contract vm.config.overrideCaller | ||
| let from = fromMaybe vm.state.contract vm.state.overrideCaller | ||
| resetCaller <- use $ #state % #resetCaller | ||
| when resetCaller $ assign (#state % #overrideCaller) Nothing |
There was a problem hiding this comment.
This should probably also set resetCaller to False at the same time
There was a problem hiding this comment.
having this on callChecks feels a bit odd to me, should it maybe live on delegateCall instead?
There was a problem hiding this comment.
Hmmm... yeah, we could set resetCaller in delegateCall. However, the let from = .. needs to be here of course. Wanna have a go at putting it in delegateCall? Just create a PR on top of this PR :)
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Co-authored-by: Emilio López <2642849+elopez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #608 there is an issue with prank. It keeps overriding the sender on lower frames as well. This should not happen.
Checklist