Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails when project depends on this package #86

Closed
diliburong opened this issue Jul 11, 2023 · 7 comments · Fixed by #87
Closed

Build fails when project depends on this package #86

diliburong opened this issue Jul 11, 2023 · 7 comments · Fixed by #87

Comments

@diliburong
Copy link

When using version 2.1.0. build failed

Module not found: Error: Package path ./keccak is not exported from package /opt/atlassian/pipelines/agent/build/node_modules/@toruslabs/base-controllers/node_modules/ethereum-cryptography (see exports field in /opt/atlassian/pipelines/agent/build/node_modules/@toruslabs/base-controllers/node_modules/ethereum-cryptography/package.json)

@diliburong
Copy link
Author

may be caused by change 06b37c5

@samaritanz
Copy link

same issue

@XenriseZPH
Copy link

XenriseZPH commented Jul 11, 2023

I have the same issue, web3auth, ethereumjs/tx depends on this package

@IDChats
Copy link

IDChats commented Jul 11, 2023

the same issue

@ArvZhou
Copy link

ArvZhou commented Jul 11, 2023

Does anyone know how to fix it?

@codingbiro
Copy link

codingbiro commented Jul 11, 2023

As @diliburong pointed out, there might have been a change in the latest release which caused this issue.

As a temporary fix, you can override the nested dependency to an older version (v2.0.0 fixed it in my case):

"dependencies": {
    "web3": "4.0.2"
},
"resolutions": {
    "ethereum-cryptography": "2.0.0"
}

I am using web3 which depends on this package, and I defined resolutions in package.json to override the dependency with Yarn. If you use NPM, take a look at: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides

@NotCentralised
Copy link

As @diliburong pointed out, there might have been a change in the latest release which caused this issue.

As a temporary fix, you can override the nested dependency to an older version (v2.0.0 fixed it in my case):

"dependencies": {
    "web3": "4.0.2"
},
"resolutions": {
    "ethereum-cryptography": "2.0.0"
}

I am using web3 which depends on this package, and I defined resolutions in package.json to override the dependency with Yarn. If you use NPM, take a look at: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides

although this builds, there are secondary effects which cause issues...

@paulmillr paulmillr reopened this Jul 11, 2023
alcuadrado added a commit that referenced this issue Jul 11, 2023
Rewrite imports: add .js extension, gh-86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants