Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3]: Indicate supported Node.js versions; test on Node.js v16 #130

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 5, 2024


  • Indicate supported Node.js versions via engines.node in manifest
  • ci: Test on node.js v16

@legobeat legobeat changed the title v23 engines [v3]: Indicate supported Node.js versions; test on Node.js v16 Sep 5, 2024
@legobeat legobeat marked this pull request as ready for review September 5, 2024 09:43
@paulmillr
Copy link
Collaborator

Can we use same engines.node that noble curves / hashes use?

@legobeat
Copy link
Contributor Author

legobeat commented Sep 6, 2024

Can we use same engines.node that noble curves / hashes use?

For sure. I was thinking it's a nice property that each supported major version is also tested in CI, which reduces the likelihood of gaps. And thinking there is little value in maintained support for odd-versioned (non-LTS) majors 19/21.

Requiring higher minor versions of the legacy versions also means we can fearlessly use newer language- and runtime features on 16.x series that may not be available in 16.0.0. Since CI is typically running on latest 16.x. For this reason, I now also added CI running explicitly on the lowest supported versions as well (16.0.0 and 18.0.0).

In any case, updated according to suggestion.

@paulmillr paulmillr merged commit da12cf7 into ethereum:v23 Sep 9, 2024
1 check passed
@legobeat legobeat deleted the v23-engines branch September 9, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants