This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Publishing to wallet.ethereum.org #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating production wallet (#407) * added @frozeman's fix (#328) * added @frozeman's fix (#328) (#329) * updates for gh-pages (#331) * updates for gh-pages (#332) * added @frozeman's fix (#328) * updates for gh-pages (#331) * Update README (#335) Changes wall to wallet * Set placeholder contract's pragma version using Mist-API (#337) * Set placeholder contract's pragma version using Mist-API * add comment * improvements * add further conditions * added missing 0x * build * Merge Develop (#338) * added @frozeman's fix (#328) * updates for gh-pages (#331) * Update README (#335) Changes wall to wallet * Set placeholder contract's pragma version using Mist-API (#337) * Set placeholder contract's pragma version using Mist-API * add comment * improvements * add further conditions * added missing 0x * build * reverted network id storage on accounts package * re-build * Error handling for previous versions of Mist (#342) * Error handling for previous versions of Mist * Better checking of Mist object * rebuild * remove amount param from coinbase widget (#347) * sticky bar is failing to stick. terrible sticky bar, fake sticky (#348) * Warning when trying to transfer a token to an empty recipient (#346) * authorize accounts callback fix * Add caret operator to contract example (#345) * Addresses need quotes (#351) I'm inferring from #118 that address parameters need quotes. * [i18n] add missing meteor package; improve error message (#357) * fix russian translation (#356) * fix renaming bug (#358) * update token contract link (#360) * minor typo and other text corrections (#359) * fixes token selection when sending via the zebra-token-list (#361) * fix * update deployContract * fix (#362) * initialize send view correctly when switching from deploy view (#363) * update TX link: testnet.etherscan.io -> ropsten.etherscan.io (#364) * numeral.js: console.warn instead of console.error (#366) * Add ES6 support; correction to fr translation (#365) * make correction to fr translation * meteor: add ES6 support * update i18n string 'accountNote' (#372) * remove whitespaces from address on token.add() (#370) * fix packages (#369) * Adding out of sync warning (#374) * Adding out of sync warning to EN and PT * Adding etherscan button on sidebar * Translations * added german * Changed http:// to https:// on one link (#384) Changed http:// to https:// on one link in README.md * update 'allow-deny' package to avert download timeout (#383) * build wallet * Darken network info font (#388) * Quick wallet fixes (#389) * fix contract ordering * check if function payable * remove console log * some typo fixes; adjust some of the supporting text (#385) * Adding two more currencies to price ticker (#387) * Adding two more currencies to price ticker * updating ethereum:tools package to 0.7.0 * Update coinbase success message (#390) * Updating coinbase success message Signed-off-by: Everton Fraga <ev@ethereum.org> * Updating coinbase success message * Removed disabled wallets (#393) * remove disabled wallets * removed disabled wallets * Temporarily removing ES6 support: fixing indexeddb driver bug (#395) * Including file to prevent 404 error (#394) * add reactive (#396) * add ens support to input fields (#398) * add ens support * make regex case insensitive * Creating travis file (#402) * Creating travis file * renaming travis file * Specifying node version * Debug 1 * Adding sudo: meteor installation * Updating ethereum-elements; building for production (#405) * Adding travis badge * reverse ENS lookup (#403) * add ens support * make regex case insensitive * fix dbissue * update files * do not pull etherscan or show currencies if on testnet * fix block watch * parenthesis * remove amount param from coinbase widget (#347) * sticky bar is failing to stick. terrible sticky bar, fake sticky (#348) * Warning when trying to transfer a token to an empty recipient (#346) * authorize accounts callback fix * Addresses need quotes (#351) I'm inferring from #118 that address parameters need quotes. * Add caret operator to contract example (#345) * [i18n] add missing meteor package; improve error message (#357) * fix russian translation (#356) * minor typo and other text corrections (#359) * fix renaming bug (#358) * update token contract link (#360) * fixes token selection when sending via the zebra-token-list (#361) * fix * update deployContract * fix (#362) * initialize send view correctly when switching from deploy view (#363) * update TX link: testnet.etherscan.io -> ropsten.etherscan.io (#364) * numeral.js: console.warn instead of console.error (#366) * Add ES6 support; correction to fr translation (#365) * make correction to fr translation * meteor: add ES6 support * update i18n string 'accountNote' (#372) * remove whitespaces from address on token.add() (#370) * fix packages (#369) * Adding out of sync warning (#374) * Adding out of sync warning to EN and PT * Adding etherscan button on sidebar * Translations * added german * update 'allow-deny' package to avert download timeout (#383) * build wallet * Changed http:// to https:// on one link (#384) Changed http:// to https:// on one link in README.md * Darken network info font (#388) * Quick wallet fixes (#389) * fix contract ordering * check if function payable * remove console log * some typo fixes; adjust some of the supporting text (#385) * Adding two more currencies to price ticker (#387) * Adding two more currencies to price ticker * updating ethereum:tools package to 0.7.0 * Update coinbase success message (#390) * Updating coinbase success message Signed-off-by: Everton Fraga <ev@ethereum.org> * Updating coinbase success message * Removed disabled wallets (#393) * remove disabled wallets * removed disabled wallets * Temporarily removing ES6 support: fixing indexeddb driver bug (#395) * Including file to prevent 404 error (#394) * add reactive (#396) * add ens support to input fields (#398) * add ens support * make regex case insensitive * Creating travis file (#402) * Creating travis file * renaming travis file * Specifying node version * Debug 1 * Adding sudo: meteor installation * Updating ethereum-elements; building for production (#405) * Adding travis badge * reverse ENS lookup (#403) * add ens support * make regex case insensitive * fix dbissue * update files * do not pull etherscan or show currencies if on testnet * fix block watch * parenthesis * Release fixes (#408) * fixes from the PR407 review * makes header work in mist properly * makes wallet header work in mist properly, only is small now in the wallet #2 * remove not existing reactiveData template helper * Editor formatting * Fixing token selection bug * fixes token switching * Release fixes (#409) * fixes from the PR407 review * makes header work in mist properly * makes wallet header work in mist properly, only is small now in the wallet #2 * remove not existing reactiveData template helper * Editor formatting * Fixing token selection bug * fixes token switching * build files * fixing grammar/whitespace on token transfer (#413) * Catalan language support. (#423) * Changed placeholder text for Token Symbol input from $ to Token Symbol on the AddToken.html modal (#420) * Fix stuck creating wallets on LES (#427) * Code legibility * Catching up wallets stuck in creating stage * Updating package version * Reverting package version * Complete Albanian translation (#424) * Add Albanian language code * Add app.sq.i18n.json * Backup * backup * completed wallet.sq translation * corrections * Adds method visibility in placeholder contract (#429) * Fixing JSON syntax error * Up to date built wallet * Reverting package update
Updating master with develop changes
Optimized Images by the GitHub [ImgBot] (29.85kb -> 0.71kb (97.64%))
…g its instructions
…might be faulty under light/remote conditions
Misc changes
wolovim
approved these changes
Oct 11, 2018
wolovim
suggested changes
Oct 11, 2018
There was a problem hiding this comment.
I take that back; noisy failures in the browser w/ metamask usage.
Timer “nodeRestarted” doesn’t exist. appStart.js:66:9
Restart app operation again appStart.js:67:9
Timer “startNode” already exists. walletConnector.js:81:3
Connect to node... walletConnector.js:82:3
Error: TypeError: "this.callback is not a function"
subscribehttp://localhost:3000/packages/ethereum_web3.js?hash=1d2cb03e4e617cc2d75a16134a4fb7cb1526c200:22753:11buildCallhttp://localhost:3000/packages/ethereum_web3.js?hash=1d2cb03e4e617cc2d75a16134a4fb7cb1526c200:22543:18_watchBalancehttp://localhost:3000/packages/ethereum_accounts.js?
...
I forget some of the context here. @ryanio what are the compatibility expectations?
(Side note: I had to update to a specific version of babel to run this locally: meteor npm install @babel/runtime@7.0.0-beta.55)
|
@evertonfraga - @ryanio reminded me that this was held up waiting for MM to merge subscription support. Looks like a PR for partial support just got merged 2 days ago. See details: MetaMask/metamask-extension#5458. |
* Bulletproofing account queries * Extracting function * Hardening address query * Not reassigning function params enables better debug sessions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #496