Edge-case offline-startup error

[luclu]

Currently Mist will error-out on the splash screen if (i) no internet connection is available and (ii) the downloaded version of geth differs from the one advertised in the bundled clientBinaries.json.

From #1534:

There seems to be a case where this fix does not suffice.

If the default config - shipped with ethereum-client-binaries - differs from the current version (e.g. of geth), I think it will try to download the older version (see clientBinaryManager.js#L181-L184). Also we can't keep the default config up-to-date on shipped installations.

Proposals

1. Disable version check of already downloaded node if clientBinaries.json can't be received from github
2. Store version of currently downloaded version in local DB

I would prefer (1).

[evertonfraga]

afaik, Mist also saves the clientBinaries.json on `Library/Mist`. You could use that version to check against the geth version

…

On Tue, Jan 10, 2017 at 10:52 AM, Luca Zeug ***@***.***> wrote: Currently Mist will error-out on the splash screen if (i) no internet connection is available and (ii) the downloaded version of geth differs from the one advertised in the bundled clientBinaries.json. From #1534 <#1534>: There seems to be a case where this fix does not suffice. If the default config - shipped with ethereum-client-binaries - differs from the current version (e.g. of geth), I think it will try to download the older version (see clientBinaryManager.js#L181-L184). Also we can't keep the default config up-to-date on shipped installations. Proposals 1. Disable version check of already downloaded node if clientBinaries.json can't be received from github 2. Store version of currently downloaded version in local DB I would prefer (1). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1569>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC4BNWUDodz7gCppAwfEuvnPa2fICPaks5rQ37ygaJpZM4LfYCB> .

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.