This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Eth 02 fixes #1483
Merged
Eth 02 fixes #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frozeman, thanks! @luclu and @evertonfraga, please review this. |
|
From the code standpoint: 👍. Looked at every non-merge commit and they all seem fine. I'll test against the ETH fixes, maybe monday morning. |
frozeman
commented
Dec 6, 2016
| @@ -28,6 +28,7 @@ process.on('loaded',function () { | |||
|
|
|||
|
|
|||
| window.mist = mist(); | |||
| window.mistMode = remote.getGlobal('mode'); | |||
There was a problem hiding this comment.
the mistMode shouldn't be exposed to dapps in browser.js.
We also don't want to require remote her, for security reasons.
The issue should be fixed in the wallet.js
frozeman
force-pushed
the
ETH-02-fixes
branch
from
ce00e89
to
67957b3
Compare
evertonfraga
approved these changes
Dec 6, 2016
| position: 1, | ||
| permissions: { | ||
| admin: true | ||
| } |
|
Security issues were tested. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves security in preloaders.
Fixes:
Moves mist API to preloader include.
Fixes callback issue in Mist API.