Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Update Readme with latest stable Electron version to avoid exception #2404

Closed
wants to merge 1 commit into from

Conversation

ltfschoen
Copy link

What do you run?
I ran the following initially to install the development version from the command line and initialise Mist:

curl -o- -L https://yarnpkg.com/install.sh | bash
brew upgrade yarn
yarn global add electron@1.3.13
yarn global add gulp
git clone https://github.com/ethereum/mist.git
cd mist
yarn
cd interface && meteor --no-release-check
electron . --loglevel debug

But running the electron command caused the following error:

$ electron --version
fs.js:640
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '~/.config/yarn/global/node_modules/electron/path.txt'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.readFileSync (fs.js:508:33)
    at Object.<anonymous> (~/.config/yarn/global/node_modules/electron/index.js:4:42)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)

So then I updated to the latest stable version of Meteor 1.5 (as only 1.4.2.3 was installed) with meteor update --release 1.5, but I still encountered the exception.

So then I updated Electron to the latest version 1.6.10 (instead of 1.3.13 as currently suggested in the Readme) with yarn global add electron@1.6.10, and this fixed the issue.

Which version do you used?
Mist 0.8.10
Electron 1.3.13 (previously) but now Electron 1.6.10 (fixed the issue)
Node 6.6
Meteor v1.5
yarn v0.24.6
gulp v3.9.1

What OS you're on?
macOS El Capitan 10.11.5

**What do you run?** 
I ran the following initially to install the development version from the command line and initialise Mist:
```
curl -o- -L https://yarnpkg.com/install.sh | bash
brew upgrade yarn
yarn global add electron@1.3.13
yarn global add gulp
git clone https://github.com/ethereum/mist.git
cd mist
yarn
cd interface && meteor --no-release-check
electron . --loglevel debug
```
But running the `electron` command caused the following error:

```
$ electron --version
fs.js:640
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '~/.config/yarn/global/node_modules/electron/path.txt'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.readFileSync (fs.js:508:33)
    at Object.<anonymous> (~/.config/yarn/global/node_modules/electron/index.js:4:42)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
```

So then I updated to the latest stable version of Meteor 1.5 (as only 1.4.2.3 was installed) with `meteor update --release 1.5`, but I still encountered the exception.

So then I updated Electron to the latest version 1.6.10 (instead of 1.3.13 as currently suggested in the Readme) with `yarn global add electron@1.6.10`, and this fixed the issue.

**Which version do you used?**
Mist 0.8.10
Electron 1.3.13 (previously) but now Electron 1.6.10 (fixed the issue)
Node 6.6
Meteor v1.5
yarn v0.24.6
gulp v3.9.1

**What OS you're on?**
macOS El Capitan 10.11.5
@evertonfraga
Copy link
Member

Hi @ltfschoen, I really appreciate your PR, but as Electron minor version (1.6.10) is tracked by webkit updates, we can't just update it on Mist and get it up to speed as we'd like. We have another PR that updates electron as well. It'll be merged as soon as we get some other aspects properly tested and solved: #2087

@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants