refactor: move history hive tests to history folder add instructions for where to put simulators #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2024
njgheorghita
approved these changes
Jan 8, 2024
simulators/README.md
Outdated
| @@ -0,0 +1,21 @@ | |||
| # Portal Simulators | |||
| Portal simulators are sorted by folders indictacting what networks are being tested. | |||
simulators/README.md
Outdated
|
|
||
| The names of folder are | ||
| - all lowercase | ||
| - dash seperated |
simulators/README.md
Outdated
| - ``beacon-state`` | ||
| - ``history-state`` | ||
|
|
||
| ## Examples of invlaid folder names :x: |
| @@ -60,15 +60,15 @@ jobs: | |||
| build-simulator-dockerfile: | |||
| docker: | |||
| - image: cimg/base:2022.06 | |||
| parallelism: 5 | |||
| parallelism: 6 | |||
There was a problem hiding this comment.
It's probably worth leaving a comment as to why the increased parallelism was necessary
ogenev
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR's should be reviewed/merged in this order
This is the first PR to add new simulators/tests for different networks like beacon.
I will do a series of PR's built off each other so reviewing/merges can be done quick and seemless.
None of these PR's should require a deep review the goal is just to move things around to make it possible to add these new simulators/tests