Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ethereum/tests fixtures #1224

Merged
merged 5 commits into from
Sep 10, 2018

Commits on Aug 29, 2018

  1. fixtures: update to db8ae9de91c303caad3eb9354015c07a0ec3adc3

    Rolls forwards up to 2018-01-22.
    
    Passing of test_state_fixtures determined using `git bisect run`.
    veox committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    3fef4bd View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. tests/test_state_fixtures(): bump fixtures and mark new test xfail.

    The upstream generated test is not sufficiently specific, and it's hard
    to determine which of the two implementations is incorrect.
    
    The principal author of the test case (Yoichi Hirai, github @pirapira)
    seems currently unavailable, so it's difficult for me to get specific
    details.
    veox committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    b11a7b8 View commit details
    Browse the repository at this point in the history
  2. eth/precompiles/modexp: fix complexity calc (length^2, not 2^2).

    There was a typo in the "complexity" calculation function, a
    special interim value from EIP-198 used to determine total gas
    use.
    
    The code path was never previously exercised.
    
    NOTE: previous-commit "fixtures bump" was to commit:
    
    9b1f07c58a70d1b17c4489c49eb9bebf4a27d290
    
    Squashed commit:
    
    tests: update "very big number" in test_modexp_gas_fee_calculation().
    
    ... and also fix that test's name, from "calculTation".
    
    The very-big-number is not actually in EIP-198; the latter has
    this to say:
    
    > it’s not possible to provide enough gas to make that computation.
    
    That's a bit cryptic, but the gist is that the most that can be
    represented in a 256-bit number is
    
    0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
    
    which is
    
    115792089237316195423570985008687907853269984665640564039457584007913129639935
    
    and that's less than the
    
    10684346944173007063723051170445283632835119638284563472873463025465780712173320789629146724657549280936306536701227228889744512638312451529980055895215896
    
    required by this vector, or even the (erroneous)
    
    708647586132375115992254428253169996062012306153720251921480414128428353393856280
    
    that was in the test previously.
    veox committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    7752f05 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2018

  1. fixtures: update to 61185fe4b8762118fe9ee318539683b47cb04ed6 + mark R…

    …evertInCreateInInit as xfail.
    
    Rolls forwards up to 2018-03-01.
    
    Break in `RevertInCreateInInit.json` determined by
    `git bisect run`.
    
    The test is marked `xfail` to expicitly highlight the fact.
    
    This is done in 3 places - all are run as part of CI.
    veox committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    11d61b0 View commit details
    Browse the repository at this point in the history
  2. fixtures: update to f4faae91c5ba192c3fd9b8cf418c24e627786312

    Determined state tests as "good" by `git bisect run`.
    veox committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    fd26ec6 View commit details
    Browse the repository at this point in the history