Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: make sure validate_header also validates seal on parent #1876

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cburgdorf
Copy link
Contributor

What was wrong?

In CliqueConsensus we can not validate a seal on a header if we haven't validated the seal of the parent. But that's exactly what can happen when using validate_header. This was causing a bug during Görli sync that I just had ignored so far.

How was it fixed?

THE IMPLEMENTATION IS JUST AN EXAMPLE

We probably want to fix that on the Clique level to not waste cpu cycles when it's not needed.

I'm going to wait until the dust around #1874 / #1875 has settled before I attempt to send a proper fix.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant